From: Sinan Kaya <okaya@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
Balakrishna Godavarthi <bgodavar@codeaurora.org>,
Loic Poulain <loic.poulain@linaro.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR)
Date: Thu, 20 Sep 2018 18:45:58 -0400 [thread overview]
Message-ID: <0ea65ca1-8d06-72d8-3bbe-693e09605a8a@codeaurora.org> (raw)
In-Reply-To: <20180920223436.202454-1-mka@chromium.org>
On 9/20/2018 6:34 PM, Matthias Kaehlcke wrote:
> On some systems the Bluetooth Device Address (BD_ADDR) isn't stored
> on the Bluetooth chip itself. One way to configure the BD address is
> through the device tree. The btqcomsmd driver is an example, it can
> read the BD address from the DT property 'local-bd-address'. It is
> also planned to extend the hci_qca driver to support setting the BD
> address through the DT.
>
> To avoid redundant open-coded reading of 'local-bd-address' and error
> handling this series adds an API to retrieve the BD address of a device
> and adapts the btqcomsmd driver to use this API.
I don't think you have got enough number of line savings to make this
code to be folded into property.c
Not my call but seems redundant IMO.
next prev parent reply other threads:[~2018-09-20 22:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 22:34 [PATCH 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR) Matthias Kaehlcke
2018-09-20 22:34 ` [PATCH 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address() Matthias Kaehlcke
2018-09-21 4:26 ` Greg Kroah-Hartman
2018-09-21 16:30 ` Matthias Kaehlcke
2018-09-21 7:13 ` Sakari Ailus
2018-09-21 12:47 ` Andy Shevchenko
2018-09-21 16:40 ` Matthias Kaehlcke
2018-09-20 22:34 ` [PATCH 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address() Matthias Kaehlcke
2018-09-20 22:45 ` Sinan Kaya [this message]
2018-09-20 23:01 ` [PATCH 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR) Matthias Kaehlcke
2018-09-20 23:03 ` Sinan Kaya
2018-09-20 23:19 ` Matthias Kaehlcke
2018-09-21 5:25 ` Sinan Kaya
2018-09-21 16:45 ` Matthias Kaehlcke
2018-09-21 16:49 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea65ca1-8d06-72d8-3bbe-693e09605a8a@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgodavar@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=mw@semihalf.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).