From: Waiman Long <longman@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v2 5/6] locking/lockdep: Decrement irq context counters when removing lock chain
Date: Tue, 14 Jan 2020 10:04:26 -0500 [thread overview]
Message-ID: <0ea82499-af07-6193-9672-4a1050442ada@redhat.com> (raw)
In-Reply-To: <20200114095345.GB2844@hirez.programming.kicks-ass.net>
On 1/14/20 4:53 AM, Peter Zijlstra wrote:
> On Mon, Dec 16, 2019 at 10:15:16AM -0500, Waiman Long wrote:
>> There are currently three counters to track the irq context of a lock
>> chain - nr_hardirq_chains, nr_softirq_chains and nr_process_chains.
>> They are incremented when a new lock chain is added, but they are
>> not decremented when a lock chain is removed. That causes some of the
>> statistic counts reported by /proc/lockdep_stats to be incorrect.
>>
>> Fix that by decrementing the right counter when a lock chain is removed.
>>
>> Fixes: a0b0fd53e1e6 ("locking/lockdep: Free lock classes that are no longer in use")
>> Signed-off-by: Waiman Long <longman@redhat.com>
> Fixes go at the start of a series, because if the depend on prior
> patches (as this one does) we cannot apply them.
>
Will put it at the front in the next version.
Cheers,
Longman
next prev parent reply other threads:[~2020-01-14 15:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 15:15 [PATCH v2 0/6] locking/lockdep: Reuse zapped chain_hlocks entries Waiman Long
2019-12-16 15:15 ` [PATCH v2 1/6] locking/lockdep: Track number of zapped classes Waiman Long
2020-01-13 14:55 ` Peter Zijlstra
2020-01-13 14:58 ` Waiman Long
2020-01-13 16:02 ` Bart Van Assche
2019-12-16 15:15 ` [PATCH v2 2/6] locking/lockdep: Throw away all lock chains with zapped class Waiman Long
2020-01-13 15:18 ` Peter Zijlstra
2020-01-13 15:44 ` Waiman Long
2020-01-13 16:05 ` Bart Van Assche
2020-01-13 16:15 ` Waiman Long
2019-12-16 15:15 ` [PATCH v2 3/6] locking/lockdep: Track number of zapped lock chains Waiman Long
2019-12-16 15:15 ` [PATCH v2 4/6] locking/lockdep: Reuse freed chain_hlocks entries Waiman Long
2020-01-13 15:51 ` Peter Zijlstra
2020-01-13 16:04 ` Waiman Long
2020-01-13 15:58 ` Peter Zijlstra
2020-01-13 16:24 ` Waiman Long
2020-01-14 9:46 ` Peter Zijlstra
2020-01-14 19:16 ` Waiman Long
2020-01-15 10:44 ` Peter Zijlstra
2020-01-15 19:26 ` Waiman Long
2020-01-13 15:59 ` Peter Zijlstra
2020-01-13 16:03 ` Waiman Long
2019-12-16 15:15 ` [PATCH v2 5/6] locking/lockdep: Decrement irq context counters when removing lock chain Waiman Long
2020-01-14 9:53 ` Peter Zijlstra
2020-01-14 15:04 ` Waiman Long [this message]
2019-12-16 15:15 ` [PATCH v2 6/6] locking/lockdep: Display irq_context names in /proc/lockdep_chains Waiman Long
2020-01-06 15:54 ` [PATCH v2 0/6] locking/lockdep: Reuse zapped chain_hlocks entries Waiman Long
2020-01-06 16:50 ` Peter Zijlstra
2020-01-06 16:52 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea82499-af07-6193-9672-4a1050442ada@redhat.com \
--to=longman@redhat.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).