From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: liulongfang <liulongfang@huawei.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>,
"Zengtao (B)" <prime.zeng@hisilicon.com>,
Oren Duer <oren@nvidia.com>
Subject: Re: [Linuxarm] Re: [RFC PATCH 2/3] vfio/hisilicon: register the driver to vfio
Date: Thu, 27 May 2021 13:30:40 +0300 [thread overview]
Message-ID: <0ed0263f-6aa7-0bfd-dc49-90308bcb512f@nvidia.com> (raw)
In-Reply-To: <0301a502747748968393aa3e3b0a849d@huawei.com>
On 5/27/2021 1:11 PM, Shameerali Kolothum Thodi wrote:
> [+]
>
> Hi,
>
>> -----Original Message-----
>> From: Jason Gunthorpe [mailto:jgg@nvidia.com]
>> Sent: 13 May 2021 19:24
>> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
>> Cc: Alex Williamson <alex.williamson@redhat.com>; liulongfang
>> <liulongfang@huawei.com>; cohuck@redhat.com;
>> linux-kernel@vger.kernel.org; linuxarm@openeuler.org
>> Subject: Re: [Linuxarm] Re: [RFC PATCH 2/3] vfio/hisilicon: register the driver to
>> vfio
>>
>> On Thu, May 13, 2021 at 05:52:56PM +0000, Shameerali Kolothum Thodi
>> wrote:
>>
>>> Since the devices we are concerned here are all integrated endpoints and if
>> the
>>> above quirk is an acceptable one, then we can use the uAPI as done in this
>>> series without overly complicating things here.
>> IMHO such a quirk in the core code should not be done. You need to
>> override this in your own driver like Max was showing.
>>
>> I think we are very close to having worked out a great solution to the
>> lingering questions on Max's last RFC, hopefully we can post an
>> updated version soon
> We have now integrated this HiSilicon ACC live migration driver into the
> proposed[0] vfio-pci-core subsystem framework. Basically now have
> a new vendor extension driver based on this framework. It indeed makes it
> easy to do the registration to vfio core and overriding of functions if required.
> Performed some basic sanity tests with the prototype and it seems to be
> working.
Great news.
>
> Also, we now managed to get rid of any access to Guest VF dev MMIO space
> during the (VFIO_DEVICE_STATE_SAVING | VFIO_DEVICE_STATE_RUNNING)
> state. However we still need to access the Guest VF MMIO space during
> few other device states eg; VFIO_DEVICE_STATE_SAVING, VFIO_DEVICE_STATE_STOP
> etc. These accesses are to save and restore device register states. As per our
> analysis the Guest vCPUs are in stopped state at these device states. So I
> hope we don't have any security related holes with these accesses.
We can start talking about more API's that are missing.
>
> Please let us know if we miss something or anything else to be taken care of with
> this approach.
>
> We are planning to send out a revised RFC soon, and if there is a plan to
> post an updated one to Max's series as mentioned above, will base
> it on that one. Please let us know.
I'll send a new version of the series soon with many improvements that
we'll taken from previous discussion.
I'll add you as CC.
>
> Thanks,
> Shameer
> [0] https://lore.kernel.org/lkml/20210310123127.GT2356281@nvidia.com/T/
>
>
next prev parent reply other threads:[~2021-05-27 10:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 3:36 [RFC PATCH 0/3] vfio/hisilicon: add acc live migration driver Longfang Liu
2021-04-13 3:36 ` [RFC PATCH 1/3] " Longfang Liu
2021-04-13 3:36 ` [RFC PATCH 2/3] vfio/hisilicon: register the driver to vfio Longfang Liu
2021-04-15 22:01 ` Jason Gunthorpe
2021-04-19 12:24 ` liulongfang
2021-04-19 12:33 ` Jason Gunthorpe
2021-04-20 12:50 ` liulongfang
2021-04-20 12:59 ` Jason Gunthorpe
2021-04-20 13:28 ` liulongfang
2021-04-20 14:55 ` Jason Gunthorpe
2021-04-20 22:04 ` Alex Williamson
2021-04-20 23:18 ` Jason Gunthorpe
2021-04-21 9:59 ` liulongfang
2021-04-21 9:59 ` liulongfang
2021-04-21 18:12 ` Alex Williamson
2021-04-26 11:49 ` liulongfang
2021-05-12 8:39 ` liulongfang
2021-05-12 12:10 ` Jason Gunthorpe
2021-05-13 2:08 ` liulongfang
2021-05-13 13:44 ` Jason Gunthorpe
2021-05-13 15:49 ` [Linuxarm] " Shameerali Kolothum Thodi
2021-05-13 17:03 ` Alex Williamson
2021-05-13 17:52 ` Shameerali Kolothum Thodi
2021-05-13 18:22 ` Alex Williamson
2021-05-13 18:31 ` Shameerali Kolothum Thodi
2021-05-13 18:34 ` Jason Gunthorpe
2021-05-13 18:24 ` Jason Gunthorpe
2021-05-13 18:35 ` Shameerali Kolothum Thodi
2021-05-27 10:11 ` Shameerali Kolothum Thodi
2021-05-27 10:30 ` Max Gurtovoy [this message]
2021-04-13 3:36 ` [RFC PATCH 3/3] vfio/hisilicom: add debugfs for driver Longfang Liu
2021-04-15 21:35 ` [RFC PATCH 0/3] vfio/hisilicon: add acc live migration driver Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ed0263f-6aa7-0bfd-dc49-90308bcb512f@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=liulongfang@huawei.com \
--cc=oren@nvidia.com \
--cc=prime.zeng@hisilicon.com \
--cc=shameerali.kolothum.thodi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).