From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbdI2M26 (ORCPT ); Fri, 29 Sep 2017 08:28:58 -0400 Received: from mail-bl2nam02on0066.outbound.protection.outlook.com ([104.47.38.66]:3941 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750954AbdI2M2z (ORCPT ); Fri, 29 Sep 2017 08:28:55 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Tom Lendacky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski Subject: Re: [Part1 PATCH v5 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support To: Borislav Petkov References: <20170927151329.70011-1-brijesh.singh@amd.com> <20170927151329.70011-3-brijesh.singh@amd.com> <20170928090242.ber7gynwaldinafa@pd.tnic> <20170928192347.gkpmpetmmp7523wu@pd.tnic> From: Brijesh Singh Message-ID: <0ed8db87-3f18-fd69-19e3-7f23a43bb8d2@amd.com> Date: Fri, 29 Sep 2017 07:28:47 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170928192347.gkpmpetmmp7523wu@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR2001CA0019.namprd20.prod.outlook.com (10.172.112.157) To CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 932325c2-a1a4-4e8a-8595-08d50735a4d3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;3:d+Gpv0HG1QNYTGieEiUnepZHICRcy88QYq8p13MCcowxSnrPbJNvi8xD5S7jG6Wqngj6NjNDV1Sg6hwbTesyTnRjm5ytmRHipfE372rWpXRvGIKzkZnUVJvuc9awsVSrCXSa+317Q2ePCFmUMTdPr59rffomwkSDvlQB8MUCt0V7ZjLW7C/iIiaTwkXOSkEzw+mnCem4G06V+BzcctkBZCFHmvcjE3A93Q5yXX4FVQGVmmfdCXcqQ3s+ovBTo/GW;25:fuOU9ID+gBB412qAnSre661/jWan9ui7lMkNm2UQd74kmamszf6f6qGtWKWolhqKh4+a6OVYLb2gTLtfJj7Or8GxJde6EIgERqmd7uAu3woBCKufyjBhdHm1hk58RR7WPS1iL1HVvsdAiHds2yiZlAkNgxvlYqDit89vbH3awwoXKBZMRQkqQf5N6DW1K8qhInUlt/xFYBqR0KvI7t5/pzfKMzuDxc5OVWUZ4I08dpSIJ7st8k+JwDwb2QqSpr4Y9X2I7p/NxMag0auAZ8iVn4HttwaZw8pHuXJNi3Po0ffhgebCXrsmk+1v7xzNWXzrEV2eNRxU7TxJoPWCemRRtg==;31:+ccoR3etHUIxcURrdEEZ3o8GoiTHmMmDj5R2LXxZ44X0ejt4ypc/r1xSiQiTFUDzWFHaNr9oDR9EyD/GS8HDo4G3ejU8KKuOtEkGCnPupqdBet4qnj2jpc8gOEcfre8rtdqcPmLPw0rXpQ8lKenCdPbYFVxaesZ0WubpfstdO2GE+pv/vgJ26Hy5v+yg6/g0N9PaEYWp5hgFkv7ULxblDOnse9xFyPuEESWhO3CMK9Q= X-MS-TrafficTypeDiagnostic: CY1PR12MB0151: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;20:Z+tlGBVuQjFKxKNrdOx2y+qsXkAomKwUe7l7q8NpDhQzuwb5BMDvxvlh9+Ib+litqjcc59/RaBE3IHo/TLxRX5GL83wJlBcnJzkhlTn5h6YnI7wQXB/sZnZ2CWEjWKYBxnWsfTlvH2oGN0O7DK89pw8JGtf4cjXtYRoaHUU3oTyAPNd1DJVKgvgQQWX7bOuyJa/OApUTNzIBflJ5qWWbd5rkqxWYBvJGodCzeAuRGkXqkS4clRC+hymmUk97uIH7A1KeRS59dcAa1O7L7g366quWB37mljCM43MWtII0yNWdYTP7f8Tu5ITCuhVITLN67rRmp4y82W0BRWUjkAlhnvfJHY60qYFZimfMQvz4/ZwLVL+Fqw6E2KvOgW0RYTyg/2lpX0sviIvVbdPGF1g5N943fd+hBX92aRGNIirN9+SVTIwqp7qCmm2VFDRYsGPzM2zTw6ey806DY8wiG+YVtnJOnHvGMw8xZdjUhGLWn+YUAxNhlS5n/rhiWYK54xQI;4:3WGml1aYRjZlSO/kKBvniVFi5jzi8ihzm4EF5hoiu5ssyOia/FQ0xxSdcDnye7oW0pk1DxRm3X/s5I2EOSdL+7ECpZ0mtjT80kcDWHf4XdRU+jFONK6g+KBSekSKYmNR4FF0wQ1ibJZhwynd+KMty1nqFS88Xw1eChhj4IIrQNoFDW+zMmgaHLqv4/enVtMhcnqgYewfHhGlemwbDtn1P5/OfV7klbefL3RUkIFv6FuXepvKkYS5a8xU1a+Pmrk1 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123564025)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0151;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0151; X-Forefront-PRVS: 0445A82F82 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(376002)(346002)(24454002)(199003)(189002)(377454003)(36756003)(101416001)(6486002)(5660300001)(6666003)(81156014)(65826007)(8936002)(81166006)(8676002)(2950100002)(3846002)(53546010)(47776003)(86362001)(6916009)(65806001)(7736002)(31686004)(305945005)(66066001)(53936002)(65956001)(83506001)(6116002)(31696002)(16526017)(58126008)(93886005)(6246003)(25786009)(64126003)(478600001)(4326008)(316002)(50466002)(33646002)(229853002)(50986999)(106356001)(54906003)(97736004)(189998001)(68736007)(54356999)(23676002)(2906002)(2870700001)(53416004)(105586002)(76176999);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0151;H:wsp101467wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:3;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzIzOlBXcXl5UzdlZlpsMFJTKzAvQWUzMXBLMlY3?= =?utf-8?B?cmVnQ3NCVG12R3QvQm90U0s5SXh6WmZ1dGJSd2FHdU4zTnppbm0zbmFBUjM5?= =?utf-8?B?NXh4cVptV0ZIUTFqa2ZTWjBNeUVDdEprcVlIVGczak1nRkNsNzM0bzhEaGs5?= =?utf-8?B?bTZvYzZJbStkY1Y5QkxjUlltNEhnQjNZYVlkNlpkQkUwY0ZhNEJTaDdKWWk3?= =?utf-8?B?ZGFBc3JtcnAxKy9qSGlLZGVvUVM3Q2I4UkQrZk1rNElKTmlnVTF1bXhhaTFY?= =?utf-8?B?ZWw0a3pVRWJsR09oRlBDVWVnMVhLNXhqQW0vUFcxZUlFajlVelhlUnlEZGN0?= =?utf-8?B?SGN6My9COEhCbnM3QklCczkyS2M5R3NMUWQwTnZQak5BeUFJQm1rN2pwQ3Nv?= =?utf-8?B?K0o5bEs0RnR1aG1ueldONGFaN1NIbkszVTRPZlJYbHFWWnlQUmNLaHRXSmRp?= =?utf-8?B?KzZJWDBOUnNnK01DTGE4TjRNODJOWmF6Unc0cFFnb1FPY3hFeXFPbXRNUFFL?= =?utf-8?B?WUxLWTl0SStSWlVkdmE3SFlKdjFkby9QcU1vbWFyYUZLWVlDTDd1dzJZZWdL?= =?utf-8?B?ZDJ0di9zZWphK0l3bVJ0T2ZSQmxQNkgwck1oOEF2UncyVlhBb214OXdsWlJU?= =?utf-8?B?S2Rwcis1TWFZbldrdmJCODE0V1dxZjNLSGpmVVU4RDVXZW9MUHM0NGZaU0hq?= =?utf-8?B?WFZnVUFjRmwyaTU0eE5HRnJ0Q3U0dzNHQVB6Nzdvdmx5WnhqVnNaN0YwbWQw?= =?utf-8?B?VGNJM200NVc2Q1RSbnZkMkpucTZUSnpWZGFuSm52Qkg4YXNHOVVTeUNXRFRT?= =?utf-8?B?WjA3b2QrWE04ejd1WlhKbkRQTFNkeXhDLzNwRTByLzhKanljWTdnMnZPc2Jn?= =?utf-8?B?UzVKL244dENrWVVRMVBKVEFRY09tdFczOEJxN09FNEgwUi8wWWtKYloxUjBn?= =?utf-8?B?cjZRRW5sTStucFludENlMld4Z2poeXlYUTM4VjZWY1lOY0kvc1U3S01DR2hQ?= =?utf-8?B?YVlEVFREVW53Q0dIOWx6MGhtRVRFOXlScXFKWDFGYUN1WG9hYkk2WDV4MTNF?= =?utf-8?B?WWd0UjY5OFN1QUYzUXVLcXZSZVpjcEhldnV1YnBPZDgyMmdvakhULzR3STZ2?= =?utf-8?B?SmtkcC91NCtCQlNWUGVaWVUyZERKZ0FDcEUwYjRpQkZDTGx0ak5VOEgxTzVy?= =?utf-8?B?OUMxaWI2MlJhV2w2eU4xQVBSOHNJdmg5cnlqQ1daNEQzeHY5ZEprZlBLTzBT?= =?utf-8?B?Ryt2QmJHNHJjMDRSa3FFZXo3S2JoS2ovT1hmWGt3eS9hYTdJZ2Z5bDRCMVhj?= =?utf-8?B?dHNKQjVhSXh4UUpPMzFURjRYbWtodHkxbGxMOVNLUWxLVWZsY0d5NkNhd2Y0?= =?utf-8?B?cEFMbU00WHp0emxQMldlcm04dzJEckQ3azVFdFhWUGJCckk0RVVlT1hZVHdk?= =?utf-8?B?b0sxTTE4cjhVSllMcE1TYUI3SUJqb3JhdHhyU1I1QlgzRzJBUGtCT2tTQkd5?= =?utf-8?B?QVUyNGQ0cVNlVlVnUzJKVyswN2pxckRjUmtvOUgrTE9DTlpzbzk0ZHo1V0d0?= =?utf-8?B?UjV5L2JzYmhPQnJDOVJsQTcyeVJMaWdrVmk1YzkzTnI3Q3ZCUVFCd2hQQnF4?= =?utf-8?B?aEZONWlrMnhhNmdkU0grcy9UUndqb2Jrc2Y1YnFOKzg4TUE1cXlVT1hjdFpT?= =?utf-8?B?enZMZThFZm9wem5tUlNDRHBIeEc1V2FXcXdWVGpXdERIazd5Q0cyanRsYjN4?= =?utf-8?B?K3JnY1N6QTJJdWk3OTBuMDMvdFJIdzk1QUd4ZDZLb3NpZkhtRkp6ajFrZkpW?= =?utf-8?B?TGlVZUhEb1lpcDhaZjNwN0RIWUdFZkRiNkVNTlFpMmk0OU1waG1BTmJZSjlB?= =?utf-8?Q?Lp2rM6IaYrY=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;6:d+RPTyQKvM/pf6Krj/qVbScrmIt/kOquVN6+wckclhqOQ6kIfzKCViMN7u5Vh1vo8sEgMLfMJATsAUMh2Ix/2KKcyNcQaf8RUfsJbIUPEDpXadA4p2nmrOAOCBLT1HTlcO3+091l7Dprv3f5mrzDZHR0PRhqHCcUicDUjsrjuaGaBymSgCIbHgu+yYo2UYJr3aWqGXb5XILrUTMrV11OZQeBTotonmhH7M0i/0PLnSi8rpe2a6oQS9yqMl7Pi1q1Qpr3cCjntbqL+gixWDiFfzwoSfshdloPYjQeOcUvP4Y7CORLOZPweCRc3XBs8Jr4fS063sSzFFbX6m7Diofw3g==;5:5BPfFdZUj+WDnUuflmDDcS+hr4HLJn5X91o3x/pAtDjDCKCGrqY83k/ixtWLqqJRxRPuIiycvgsvIDvMY9VsiHPa/1Vedm6jhBWn6g2UKOv87QFQaMlCncvvyr6gF642b96EnwG5v9QnRi6pbbtHUw==;24:Ewyxgzi2RRc0L1N8sBw3iMTg7Bd6LZe02BqShlGp7ECK5ox2hB6R3p0g0ABC3pubkqWPOmNpyiy8rjc//P1Preio+9qy3G8pTrCsdsMca/c=;7:SOhCFxaHftc8WNAgwJh30EsnO3y8ldbGQx5q+l5V+UieP+67Pft6F0zf852IF+JB7A5/SOrIWzQQT1CqZNz0isw/7TkXcgLrwtQzCrWjkkUOmLkcDAuOtHA0o12sF9Gef6qQWQFh9PKF+AYytQSU2L/V5MC0cATI9rEP7kmOoiinubDCzILfjHU9mSBWQ7O8lzxuqRJzkgWHVYNNrDqZP5Ie771SbeX5Q2qi31blHXE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;20:CEQ//gcatmXLud6aEjL/z3vUdvJxdQusEzguCRweSy2OIuInx1JttUZUVaGFJweOYKAK0Ao0YR+kKhGTmjmCIy1yPNRiqMRzeiHdPkWy+oWT/JfSRJMtwmbmLbQI9b3KBkK+gT0s9EVo4VwCZi2wndgA2iAdFrpaPLtsOWXzTnM5hGdJg/9JVrEQRsHAt2UDZyDkEVioIDmW8GDQazWGg2ky0zV3s6wNynIpEliFgtfCccsUP2RWSNNJ63J1Uhf6 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2017 12:28:50.7467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/28/17 2:23 PM, Borislav Petkov wrote: ... > So actually we need chicken bits to be able to *enable* both when > CONFIG_AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT is not set. > > I.e., > > * mem_encrypt=on - both SME and SEV enabled > > * mem_encrypt=smeonly - only SME, no SEV on the host. This option will > basically prevent from using any SEV guests and make the SEV part of the > code inactive. I.e., sev_active() and sev_enabled should be false. As > you say above, we should clear X86_FEATURE_SEV, yes. > > * mem_encrypt=off - neither SME/SEV are enabled. > > And =on and =off we already have. > > How does that sound? if we are adding a chicken bits then I think we should do it for both "smeonly" and "sevonly". We can boot host OS with SME disabled and SEV enabled, and still be able to create the SEV guest from the hypervisor. How about this ? mem_encrypt=on     both SME and SEV enabled mem_encrypt=sev    only SEV enabled mem_encrypt=sme   only SME enabled mem_encrypt=off     neither SME/SEV are enabled -Brijesh