From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B8DAC04AA5 for ; Thu, 25 Aug 2022 06:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232972AbiHYGSo (ORCPT ); Thu, 25 Aug 2022 02:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232970AbiHYGSm (ORCPT ); Thu, 25 Aug 2022 02:18:42 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F137CA00E6 for ; Wed, 24 Aug 2022 23:18:40 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id bt10so13921925lfb.1 for ; Wed, 24 Aug 2022 23:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=LCeRgAr90AjP72BARFiQs5/0imRongy9yblqwBgpMJw=; b=c3RlXRDaCp4vYWxqcyLpXjoAHiDJ0wrIIcONyeaAraWpAjQYEC51alebj1AQrr5xJ3 0JCZnlpUQtsKJjJiTgWDccNqR6NMnrbXCDj6LAnTJ6rw9OFPRtR5zWwLrhJFNhECVhBz UOunN4yWD7EJvjCey/CBpxxnCxhmToSfFIgqj4U0BuArgrJYUp+NZ8aYfT5EZkeTBjEt fnvIoiqL9uoXq6oYoaeSf7SFQXkoBLaowtzcRdPB62ZimXRQh0OvG09QjFjQE2k1SyUK PSGe3qgXUg0uN95oS5On0SV6qM7neLlUYfAPe5iG5411BzKn1lvKoSeZYwmAX8HLAkev 7Dqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=LCeRgAr90AjP72BARFiQs5/0imRongy9yblqwBgpMJw=; b=wFtUhfQ1FjHIFbE6OBSSmwbWs6b++sbjr8z9oeMfpq/aLu0i14rNIuarRYyZz/nVDp AGGeOY4hZzoGM35e+jZopQACJ7KBJYI1MpNvvifYCavngE3+2pLQXa9uiBB4a9cCASjf QHiwaPsHBgb4/r0MLiYHJXTo8HfASPuj7OrTomvQx/X1psIokXgCrybyukf23YhbNbnP V2HYN+3T5SwmEbUfXHuuUT1Qd5b0gkz6XHrGDYX1Zp44rL2kuCHpQxIqTEmrpgopcMr5 k7qtrlLBTkCpcqQdJ6U0Vj8TnIaQQRoVLC+4UOVfhVtyPjPV6mKSWcPR6GJ0g+45nGCA /TWg== X-Gm-Message-State: ACgBeo2NUFKKVwjewL3S9eTqvLPIMYGN74VJDmeeiWlHwyxYvJ9fTAFA fXRftx6qurgyjoEIw/Fkrt7mGw== X-Google-Smtp-Source: AA6agR75ynzRVgvfBbdqJ2QkXycl9WBPmjwpM9MQUP9CsZJX93WYal3zBWqrzkkwzk66jgGdDVldhw== X-Received: by 2002:a05:6512:2302:b0:492:ce48:1bab with SMTP id o2-20020a056512230200b00492ce481babmr612617lfu.266.1661408319341; Wed, 24 Aug 2022 23:18:39 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id o13-20020ac25e2d000000b00492b7d7ee20sm323634lfg.87.2022.08.24.23.18.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 23:18:38 -0700 (PDT) Message-ID: <0eea5c56-534a-aec6-b9f1-dd306fccf282@linaro.org> Date: Thu, 25 Aug 2022 09:18:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v5 5/7] dt-bindings: net: dsa: mediatek,mt7530: define port binding per switch Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220824104040.17527-1-arinc.unal@arinc9.com> <20220824104040.17527-6-arinc.unal@arinc9.com> From: Krzysztof Kozlowski In-Reply-To: <20220824104040.17527-6-arinc.unal@arinc9.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/08/2022 13:40, Arınç ÜNAL wrote: > Define DSA port binding per switch model as each switch model requires > different values for certain properties. > > Define reg property on $defs as it's the same for all switch models. > > Remove unnecessary lines as they are already included from the referred > dsa.yaml. > > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 55 +++++++++++-------- > 1 file changed, 33 insertions(+), 22 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 8dfc307e6e1b..a6003db87113 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -127,37 +127,45 @@ properties: > ethsys. > maxItems: 1 > > -patternProperties: > - "^(ethernet-)?ports$": > - type: object > - > - patternProperties: > - "^(ethernet-)?port@[0-9]+$": > - type: object > - description: Ethernet switch ports > - I don't see improvements here. We might have here misunderstanding, because I mentioned it several times yet no effect. This hunk with reg and maybe few other properties which are always applicable should stay. You do not need any defs for this binding... Best regards, Krzysztof