From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>,
Krzysztof Kozlowski <krzk@kernel.org>,
alsa-devel@alsa-project.org
Cc: Cheng Shengyu <cheng.shengyu@zte.com.cn>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Takashi Iwai <tiwai@suse.com>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Yi Wang <wang.yi59@zte.com.cn>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: samsung: odroid: fix an use-after-free issue for codec
Date: Sun, 14 Jul 2019 10:47:20 +0200 [thread overview]
Message-ID: <0eeabac6-edbd-b829-817f-ffff87e1a825@web.de> (raw)
In-Reply-To: <1562989575-33785-2-git-send-email-wen.yang99@zte.com.cn>
> @@ -317,6 +316,7 @@ static int odroid_audio_probe(struct platform_device *pdev)
> goto err_put_clk_i2s;
> }
>
> + of_node_put(codec);
I would prefer to avoid a bit of duplicate source code also at this place.
Thus I would find a statement like “goto put_node;” more appropriate here.
> return 0;
>
> err_put_clk_i2s:
Regards,
Markus
next prev parent reply other threads:[~2019-07-14 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 3:46 [PATCH 0/2] ASoC: samsung: odroid: fix err handling of odroid_audio_probe Wen Yang
2019-07-13 3:46 ` [PATCH 1/2] ASoC: samsung: odroid: fix an use-after-free issue for codec Wen Yang
2019-07-14 8:47 ` Markus Elfring [this message]
2019-07-14 10:55 ` [1/2] " Markus Elfring
2019-07-16 9:06 ` [PATCH 1/2] " Krzysztof Kozlowski
2019-07-16 18:18 ` Applied "ASoC: samsung: odroid: fix an use-after-free issue for codec" to the asoc tree Mark Brown
2019-07-13 3:46 ` [PATCH 2/2] ASoC: samsung: odroid: fix a double-free issue for cpu_dai Wen Yang
2019-07-14 12:47 ` [2/2] " Markus Elfring
2019-07-16 9:06 ` [PATCH 2/2] " Krzysztof Kozlowski
2019-07-16 18:18 ` Applied "ASoC: samsung: odroid: fix a double-free issue for cpu_dai" to the asoc tree Mark Brown
2019-07-14 10:07 ` [PATCH 0/2] ASoC: samsung: odroid: fix err handling of odroid_audio_probe Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eeabac6-edbd-b829-817f-ffff87e1a825@web.de \
--to=markus.elfring@web.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cheng.shengyu@zte.com.cn \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).