From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD4DAC43603 for ; Sat, 7 Dec 2019 01:09:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 837612064B for ; Sat, 7 Dec 2019 01:09:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="erVUUFtB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726475AbfLGBJn (ORCPT ); Fri, 6 Dec 2019 20:09:43 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38291 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbfLGBJn (ORCPT ); Fri, 6 Dec 2019 20:09:43 -0500 Received: by mail-wm1-f68.google.com with SMTP id p17so9105260wmi.3 for ; Fri, 06 Dec 2019 17:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yD+Kc1w68swJeTB/Vxg8esU+QpTKf/Y2rxrM02hsM8E=; b=erVUUFtB6mpxaavF/Ysp04B0vSbTaHZdphEw6PTLPxx4Jh1Lr2T0Jk8GcojtMGgxI3 DBrW0+V6iZJe3f8YfhDCKupEhidu6nFRAn3EgPh/iKNjplr7NjNrVYW9yeieGHE8n8B6 82lbOmdaJ/+WYpSO8E560+uoe6p3ly2WEZ9B4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yD+Kc1w68swJeTB/Vxg8esU+QpTKf/Y2rxrM02hsM8E=; b=S8Vv1Mq8PY5HQH14pizmxANC2VdKix08Wub6I2Ye//727HPJlYeOnsA7PLn7Qq7YBl Fez8SpeK9J82yfqGBxQ8bnneht08RBoVAwHDOH+p/GQtIfrORl6ChSMnGAAjTZvtnSxl pwcZW9Vm5Ev7332q3nSGdyJ6p8agoPNLf9wzV+iSEZ1FCDony99w+Ti5XqqFjkU4Y2Qi hLCL0LPOqbjGjJudRYR0SnEUR6i5laOrQTx+isjPVv6KGdNqLHtaCCHsa0xa235HaSqH FQMe6fq7iTjjxVrmH5GYRtA2QMj1fUWsNGSSdlosRXz7ZGmASSxtHUzBRrAJPpHy2KcK 7iOA== X-Gm-Message-State: APjAAAW5f8k6j8n2XgUDCdKBQT0hOxDNizkWsbTtNGWAS8xSmqd0YJMN GPXU3JZoh5Cg3HjG4nkW6Pz6RA== X-Google-Smtp-Source: APXvYqxObGo3CZK1oMZD8K04TAdbPkiFZl31iS0EfNlkm/zzbTK+0LJdmEc/w156VyiqFzklzdlVMA== X-Received: by 2002:a7b:cbc4:: with SMTP id n4mr12296535wmi.118.1575680980554; Fri, 06 Dec 2019 17:09:40 -0800 (PST) Received: from rj-aorus.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id d14sm18881353wru.9.2019.12.06.17.09.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Dec 2019 17:09:39 -0800 (PST) Subject: Re: [PATCH 1/2] dt-bindings: soc: Add binding doc for iProc IDM device To: Florian Fainelli , Rob Herring , Mark Rutland Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Rayagonda Kokatanur References: <20191202233127.31160-1-ray.jui@broadcom.com> <20191202233127.31160-2-ray.jui@broadcom.com> <62254bbb-168e-c0ad-a72d-bd659a2c23fa@gmail.com> From: Ray Jui Message-ID: <0f0e965b-2e57-8b6b-0c72-1a1008497793@broadcom.com> Date: Fri, 6 Dec 2019 17:09:34 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <62254bbb-168e-c0ad-a72d-bd659a2c23fa@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/5/19 4:09 PM, Florian Fainelli wrote: > On 12/2/19 3:31 PM, Ray Jui wrote: >> Add binding document for iProc based IDM devices. >> >> Signed-off-by: Ray Jui > > Looks good to me, it's 2019, nearly 2020, maybe make this a YAML > compatible binding since it is a new one? > Sorry I am not aware of this YAML requirement until now. Is this a new requirement that new DT binding document should be made with YAML format? Thanks, Ray >> --- >> .../bindings/soc/bcm/brcm,iproc-idm.txt | 44 +++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,iproc-idm.txt >> >> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,iproc-idm.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,iproc-idm.txt >> new file mode 100644 >> index 000000000000..388c6b036d7e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,iproc-idm.txt >> @@ -0,0 +1,44 @@ >> +Broadcom iProc Interconnect Device Management (IDM) device >> + >> +The Broadcom iProc IDM device allows control and monitoring of ASIC internal >> +bus transactions. Most importantly, it can be configured to detect bus >> +transaction timeout. In such case, critical information such as transaction >> +address that caused the error, bus master ID of the transaction that caused >> +the error, and etc., are made available from the IDM device. >> + >> +------------------------------------------------------------------------------- >> + >> +Required properties for IDM device node: >> +- compatible: must be "brcm,iproc-idm" >> +- reg: base address and length of the IDM register space >> +- interrupt: IDM interrupt number >> +- brcm,iproc-idm-bus: IDM bus string >> + >> +Optional properties for IDM device node: >> +- brcm,iproc-idm-elog: phandle to the device node of the IDM logging device >> + >> +------------------------------------------------------------------------------- >> + >> +Required properties for IDM error logging device node: >> +- compatible: must be "brcm,iproc-idm-elog"; >> +- reg: base address and length of reserved memory location where IDM error >> + events can be saved >> + >> +------------------------------------------------------------------------------- >> + >> +Example: >> + >> +idm { >> + idm-elog { >> + compatible = "brcm,iproc-idm-elog"; >> + reg = <0x8f221000 0x1000>; >> + }; >> + >> + idm-mhb-paxc-axi { >> + compatible = "brcm,iproc-idm"; >> + reg = <0x60406900 0x200>; >> + interrupt = ; >> + brcm,iproc-idm-bus = "idm-mhb-paxc-axi"; >> + brcm,iproc-idm-elog = <&idm-elog>; >> + }; >> +}; >> > >