linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Guenter Roeck <linux@roeck-us.net>, Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, James.Bottomley@HansenPartnership.com,
	kirill.shutemov@linux.intel.com, linux-parisc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: fix compilation errrors
Date: Thu, 22 Aug 2019 22:53:51 +0200	[thread overview]
Message-ID: <0f27b102-471a-e472-3e69-d9883a36efeb@gmx.de> (raw)
In-Reply-To: <20190815210208.GA9868@roeck-us.net>

On 15.08.19 23:02, Guenter Roeck wrote:
> On Thu, Aug 15, 2019 at 04:53:05PM -0400, Qian Cai wrote:
>> The commit 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix
>> variable 'p4d' set but not used") converted a few functions from macros
>> to static inline, which causes parisc to complain,
>>
>> In file included from ./include/asm-generic/4level-fixup.h:38:0,
>>                   from ./arch/parisc/include/asm/pgtable.h:5,
>>                   from ./arch/parisc/include/asm/io.h:6,
>>                   from ./include/linux/io.h:13,
>>                   from sound/core/memory.c:9:
>> ./include/asm-generic/5level-fixup.h:14:18: error: unknown type name
>> 'pgd_t'; did you mean 'pid_t'?
>>   #define p4d_t    pgd_t
>>                    ^
>> ./include/asm-generic/5level-fixup.h:24:28: note: in expansion of macro
>> 'p4d_t'
>>   static inline int p4d_none(p4d_t p4d)
>>                              ^~~~~
>>
>> It is because "4level-fixup.h" is included before "asm/page.h" where
>> "pgd_t" is defined.
>>
>> Fixes: 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix variable 'p4d' set but not used")
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Qian Cai <cai@lca.pw>
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Helge Deller <deller@gmx.de>

Helge

  reply	other threads:[~2019-08-22 20:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 20:53 [PATCH] parisc: fix compilation errrors Qian Cai
2019-08-15 21:02 ` Guenter Roeck
2019-08-22 20:53   ` Helge Deller [this message]
2019-08-22 23:04     ` Guenter Roeck
2019-08-22 23:15       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f27b102-471a-e472-3e69-d9883a36efeb@gmx.de \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).