From: Samuel Holland <samuel@sholland.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
Maxime Ripard <maxime@cerno.tech>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] mmc: sunxi-mmc: Fix clock refcount imbalance during unbind
Date: Sun, 14 Aug 2022 12:56:56 -0500 [thread overview]
Message-ID: <0f40b1cf-1f5d-41b6-04bb-0566f18cd91e@sholland.org> (raw)
In-Reply-To: <21565294.EfDdHjke4D@jernej-laptop>
On 8/14/22 3:22 AM, Jernej Škrabec wrote:
> Dne sreda, 10. avgust 2022 ob 04:25:09 CEST je Samuel Holland napisal(a):
>> If the controller is suspended by runtime PM, the clock is already
>> disabled, so do not try to disable it again during removal. Use
>> pm_runtime_disable() to flush any pending runtime PM transitions.
>>
>> Fixes: 9a8e1e8cc2c0 ("mmc: sunxi: Add runtime_pm support")
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>
> Did you get any warnings for unbalanced disable calls?
Yes, I got warnings while I was doing unbind/bind cycles to force the SDIO WiFi
driver to reload.
Regards,
Samuel
> Anyway:
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
>
> Best regards,
> Jernej
>
>
next prev parent reply other threads:[~2022-08-14 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 2:25 [PATCH] mmc: sunxi-mmc: Fix clock refcount imbalance during unbind Samuel Holland
2022-08-14 8:22 ` Jernej Škrabec
2022-08-14 17:56 ` Samuel Holland [this message]
2022-08-15 10:11 ` Ulf Hansson
2023-01-01 19:25 ` Samuel Holland
2023-01-02 15:07 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f40b1cf-1f5d-41b6-04bb-0566f18cd91e@sholland.org \
--to=samuel@sholland.org \
--cc=andre.przywara@arm.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime@cerno.tech \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).