From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Lucas Tanure <tanureal@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH] ASoC: cs35l41: Set the new legacy DAI naming flag
Date: Thu, 21 Jul 2022 17:54:15 +0300 [thread overview]
Message-ID: <0f413cf5-fadc-6fe8-cadc-2c9526d4a2e2@collabora.com> (raw)
In-Reply-To: <20220721131928.GD92394@ediswmail.ad.cirrus.com>
Hi Charles,
On 7/21/22 16:19, Charles Keepax wrote:
> On Thu, Jul 21, 2022 at 03:14:54PM +0300, Cristian Ciocaltea wrote:
>> Unlike most CODEC drivers, the CS35L41 driver did not have the
>> non_legacy_dai_naming set, meaning it uses the legacy naming.
>>
>> The recent migration to the new legacy DAI naming style has broken
>> driver functionality because it is now expected to set the new legacy
>> DAI naming flag in order to instruct the core subsystem to use the
>> legacy name format on DAI registration.
>>
>> Let's fix this by setting the legacy_dai_naming flag accordingly.
>>
>> Fixes: bc949a3b4af3 ("ASoC: core: Switch core to new DAI naming flag")
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>
> It is really not intended for any CODECs to be using the legacy
> DAI naming, it was only intended for platform side components.
> Would be good if you had some details on the affected system and
> if that could be updated to use the non legacy DAI naming?
I'm currently testing this on Valve's Steam Deck. Let me also check what
would be the required changes in order to switch to using a non-legacy
DAI naming.
> Thanks,
> Charles
next prev parent reply other threads:[~2022-07-21 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 12:14 [PATCH] ASoC: cs35l41: Set the new legacy DAI naming flag Cristian Ciocaltea
2022-07-21 13:19 ` Charles Keepax
2022-07-21 14:54 ` Cristian Ciocaltea [this message]
2022-07-21 23:38 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f413cf5-fadc-6fe8-cadc-2c9526d4a2e2@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).