From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1EF7C432BE for ; Fri, 23 Jul 2021 09:18:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA65560EC0 for ; Fri, 23 Jul 2021 09:18:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234155AbhGWIh2 (ORCPT ); Fri, 23 Jul 2021 04:37:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232394AbhGWIh1 (ORCPT ); Fri, 23 Jul 2021 04:37:27 -0400 Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26D56C061575; Fri, 23 Jul 2021 02:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JtK3F4ur0xXfBHq8xF2md1hvbLFHPIXsScOT7FC0TmA=; b=14617pCIhQkbwxkrZKJUiAaqsS G73+8csRqRRchneM8D5h9nEY7r68bTusQyVhYoXRFixZhkZfQBBps9y+otlHNFp5vyFGEaKXvpqM7 sOd5YDjjvOxGp5SIecm16We7x42yZtpxeql7roGROnm6QP3vJxHIs0L7Qx29LDG+zJDeE1onQu3uh NQznJUuvDO5ZfqDcIidnTtz5/MoWQ+kr4NXSzXpym/Sx0CEc++t8Sy4FoTgop9V3xN+TmprbPcMKW xnJ9512y5lS1uaRiywjTK/5SfqdlrlNFSwW/Xi8Il3szZMNmiBoGvA/RqhIxhXgwKJ7DIevM6EifA heWuK52w==; Received: from dsl-hkibng22-54f986-236.dhcp.inet.fi ([84.249.134.236] helo=[192.168.1.10]) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1m6rJc-0006dv-Rh; Fri, 23 Jul 2021 12:17:56 +0300 Subject: Re: [PATCH] gpu: host1x: select CONFIG_SYNC_FILE To: Arnd Bergmann , Thierry Reding , Mikko Perttunen Cc: Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210723091424.1682193-1-arnd@kernel.org> From: Mikko Perttunen Message-ID: <0f4d1f0a-c313-a60e-6a72-fd4b0c757bc3@kapsi.fi> Date: Fri, 23 Jul 2021 12:17:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210723091424.1682193-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 84.249.134.236 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, I think the best fix for this is to just remove that function -- it is currently not used anywhere. I posted a patch to do that, but Thierry is currently on vacation so it hasn't been picked up yet. thanks, Mikko On 7/23/21 12:14 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > With the addition of the DMA fence, the host1x driver now fails to > build without the sync_file helper: > > arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd': > fence.c:(.text+0x624): undefined reference to `sync_file_create' > > Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/host1x/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig > index 6dab94adf25e..6f7ea1720a39 100644 > --- a/drivers/gpu/host1x/Kconfig > +++ b/drivers/gpu/host1x/Kconfig > @@ -3,6 +3,7 @@ config TEGRA_HOST1X > tristate "NVIDIA Tegra host1x driver" > depends on ARCH_TEGRA || (ARM && COMPILE_TEST) > select IOMMU_IOVA > + select SYNC_FILE > help > Driver for the NVIDIA Tegra host1x hardware. > >