From: "Gole, Dhruva" <d-gole@ti.com>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, linux-spi@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: spi-mem: Fix typo (of -> or)
Date: Fri, 28 Oct 2022 12:00:23 +0530 [thread overview]
Message-ID: <0f5235b8-9f35-6f7c-37b4-8094e476fbd4@ti.com> (raw)
In-Reply-To: <20221008151459.1421406-1-j.neuschaefer@gmx.net>
Hi Jonathan,
On 10/8/2022 8:44 PM, Jonathan Neuschäfer wrote:
> In this instance, "or" makes more sense than "of", so I guess that "or"
> was intended and "of" was a typo.
Using "I guess" is generally discouraged in commit messages. Please read
up the documentation
on submitting patches:
> Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to
do frotz”, as if you are giving orders to the codebase to change its
behaviour.
link:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> include/linux/spi/spi-mem.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
> index 2ba044d0d5e5b..8e984d75f5b6c 100644
> --- a/include/linux/spi/spi-mem.h
> +++ b/include/linux/spi/spi-mem.h
> @@ -225,7 +225,7 @@ static inline void *spi_mem_get_drvdata(struct spi_mem *mem)
> /**
> * struct spi_controller_mem_ops - SPI memory operations
> * @adjust_op_size: shrink the data xfer of an operation to match controller's
> - * limitations (can be alignment of max RX/TX size
> + * limitations (can be alignment or max RX/TX size
> * limitations)
> * @supports_op: check if an operation is supported by the controller
> * @exec_op: execute a SPI memory operation
> --
> 2.35.1
>
--
Regards,
Dhruva Gole <d-gole@ti.com>
next prev parent reply other threads:[~2022-10-28 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 15:14 [PATCH] spi: spi-mem: Fix typo (of -> or) Jonathan Neuschäfer
2022-10-28 6:30 ` Gole, Dhruva [this message]
2022-10-28 9:55 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f5235b8-9f35-6f7c-37b4-8094e476fbd4@ti.com \
--to=d-gole@ti.com \
--cc=broonie@kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).