From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033674AbdDTVyM (ORCPT ); Thu, 20 Apr 2017 17:54:12 -0400 Received: from mail-he1eur01on0114.outbound.protection.outlook.com ([104.47.0.114]:47182 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S947841AbdDTVyI (ORCPT ); Thu, 20 Apr 2017 17:54:08 -0400 Authentication-Results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller To: Greg Kroah-Hartman References: <1492101794-13444-1-git-send-email-peda@axentia.se> <1492101794-13444-4-git-send-email-peda@axentia.se> <20170418085156.GA4773@kroah.com> <20170418114430.GA1496@kroah.com> CC: , Wolfram Sang , Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , , , , , Andrew Morton , Colin Ian King , Paul Gortmaker , Philipp Zabel , From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <0f605429-afa2-2818-96d5-5da0bad122d6@axentia.se> Date: Thu, 20 Apr 2017 23:53:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM3PR07CA0146.eurprd07.prod.outlook.com (10.165.223.32) To HE1PR0202MB2555.eurprd02.prod.outlook.com (10.168.184.8) X-MS-Office365-Filtering-Correlation-Id: 36612343-9c92-464e-a370-08d48837c22b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:HE1PR0202MB2555; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;3:wqQtXuXtcfG+FxFe4sAWzQG+cQSn371c4r7/VTxBzQzMOrOv3/Ydpqso+BjP4TwJXiChxB8n+VjstFmuNz4qdISpa4jFaF581dL7YDv1OTk475sxOnBEdEkz0MM44Vk3qK6EFUr6R1O9wmfi0z9ETmGmZFmVx5rZLoT5M8sOSLUEf+lkvgp8SDXLtqbHBLTCk6DvQyVEHLoTrOpEOFw/QcWccxx5DMGcFrZb6oIX0Ririui/AwC6oDmt0QzJU8lmWTMLEGjB3uwKyMtsbKitpexKeNSA3rRSmnXltW+ZZdEpNzuPgl6MrFF1TWU8Z2mG;25:0HPa5uOegvzRREYbHPz2RUSxhB1D8yOVZ3LKz6VSiLhI6q3B4W68vXGQRppew0mj6sE9ZoVPgkBfRaNA8PcTlRcLrQDYFK3pl81bBrjwRHcJHAp3LQCDLw4f5jbW01zc8Sd7kMOZTZ4AD9hhhJn+6f1vf7wy7J3o4KlVUWQTaHwccTCS02eOVQep6Tsa8JMUcx+HGYhfrmw1r46VGp0GGFAt/IMG6FqSG9J+mMhj+Snlp071um3jr7nQJL0XbuZDThuF8jXynF4cCn++k0yp+d/yOb9nIgyZQzOaxPDs/7wv73QLltAiTcRyXmDGadNVm31WY8jGFapwWkRb9VIZAkvOrGf+QwXratNrPwnr6xrAk81xRDl4iTmNID5JPpqxOtl8R7oP3WhZBpf0LZ28v1zQ1zksOuVJst+fGsJj6Qv1i5Xb63vHC0gRbdoCDbHbze29iVF6N223UsxpL+gpQg== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;31:vTAkIshfU5eBeJMXxgHQ6b8REQnB7ZPdFE464FxuIsgP0qDZI8hMLqK0mdCgB8vyN2fznhYFTJ2f+Os2EdvUlXSi6NLQPqTgwrPmtpxyw59RuQ5nnrjqExJoxSBkvWNcQ+Hc0GKCSYbMXzkde++xRHvknb6oCx/omUze6DAkojX07ZtswQqjOoBOH+ndOWLi4SY8BwamRmfQXLNDN4MSUyi6p+JN9JQLe5ADJbB1xFq5l7iDjV3hmYkOX0AoyP/IQRq9ywF35OuLgnJpfaBnJw7ZfQMq3DsswNS1F1wfNXo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(2016111802025)(6043046)(6072148);SRVR:HE1PR0202MB2555;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0202MB2555; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;4:PkpbMgxL6V6WYnKi78ZXTNKUZuq7d/uTQI3V5YN/kRThvr2fHAoIJVIM5mPP7HMKd26mTqzk2OnFq7M2JgmLQR31Ovj+dbKKcVQjwxpnGfRLYqvdmrIHzQh2dAUP7TE61GeOzU8X6vtXmJ8VW0KPw5GLC3BMTPi0X2Sdkt+BG11omoHlkZ9RN89Ec99CWStfxSn/tGHof2UMUys922jIAntJ64bGyxL3kZjj5/2cy4hd1KtgL5Kzqd6/aoO+MC0qM755/SrGoW4M3SB9niPuTtLwnLr52YzD68ubTMDXSQ7ZydcdGGbycb8xXskX5iad+f722xOv7WaHz25jQDFmtyZ9SboxQnxOHK8uSOhzP6rHdAo8DyIbXRRdgnaFSVFeruq52Yfl3zsX4cTgkgumD0ZcSYetlA5Rl7Z90iGIOMrin2X9/BP8OObQUgmVBtdV/zPHQr++JAzjJwxy4tPqUYxLFJMiugIj3AKApi8ILU+TM5yFb9Wdo5xG3FuOY96E6UmlXidiFcKFhbI4oMDbiHH9kHKzbNNI8FrbfuUhyupH6/hGJye9GhsgzvKNkHe87cQIUxCSA+GkNRQlR5wSSUvm84JZ1gvFJLjOXeZWkAA11D6TiMjH0zNof5yEyFbXqP8cPTDtLQiMQn8EP2fF6uikhgE+qAfnETZdpvnD/UgqLvz8BxQIo/q/5KAw5KkQfSVdesdJo8ou7pzrULlbFjZUn1QwXFAh58WB7eOG8HflNa8McLlhslu2WDBftGlepVYwdlfpT4wOxyfpm5UMQQ== X-Forefront-PRVS: 02830F0362 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39400400002)(39830400002)(39450400003)(39410400002)(377424004)(24454002)(3846002)(230700001)(6486002)(305945005)(6116002)(25786009)(90366009)(8666007)(83506001)(74482002)(54356999)(117156002)(77096006)(7736002)(50986999)(54906002)(65806001)(65956001)(6246003)(53936002)(50466002)(23746002)(33646002)(76176999)(47776003)(110136004)(66066001)(38730400002)(53546009)(4326008)(31686004)(31696002)(42186005)(6666003)(93886004)(2906002)(2950100002)(36756003)(6916009)(81166006)(189998001)(4001350100001)(8676002)(7416002)(86362001)(5660300001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0202MB2555;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR0202MB2555;23:P7nO4rNUOO7TuvDJ8EQswlZ8+wh5efz+iJT?= =?Windows-1252?Q?mI22H2pRLlq4A3OCH4OwEq3UK8ncpP855Gc6UB2Iq6Ps3FO7AUCCTqK+?= =?Windows-1252?Q?G0DGfwzRvxc0LQdWimcSwBoRxEbZefuoebhRoVIArESl+23QbTA5uifj?= =?Windows-1252?Q?6JHHe7xIh1pScyfv1gAQPZQ6yKo66bEYW+wCf7sQZIjF8nBqtMKW8cCT?= =?Windows-1252?Q?E2TF1yZ4XgrO//G7XYhYuUyJRv3QFrXS8hL3q3Z3QeYIy1Th0DaIa2Qx?= =?Windows-1252?Q?C/YV0N0oWjRtnABSsaB4jgPz++v0/g3LzURFOdPefzZf2BceV5I7R66+?= =?Windows-1252?Q?SdHGDHrCYl+7R/pau8ZcmOVWw2rfG3Ddx4xvUt+kM/JzORYUryPsDsdJ?= =?Windows-1252?Q?6nyJ1uzkWAiJoqOQ5SFyP588ZdqF3ivcN9DRSQKgc5d4Qu8tPvcK7c7M?= =?Windows-1252?Q?stXbrWYC5ekO/vMK/PkwTRHvCtNaYWYjrQoztEQdHQllajTndBLnQ+iB?= =?Windows-1252?Q?HvJYKtv1C1TAa+qYImGWxFUvrNfGykBjpdmKT50LJUZPLF0zMj1+a1LT?= =?Windows-1252?Q?DkRTYVapb3vgr3jsDTa4S77LRlHO+c3KCgTKc6tff0HKLDTSnl71jj94?= =?Windows-1252?Q?ZmmWJYg7tWt7sgsMq2fWupTkW0+qys7Y+XRZqrl8HzlbafKcrSBesxJ/?= =?Windows-1252?Q?SdSeeBMueo2b/5JmZ9nFEwKkjaurRwcqrbLNcOEX+rT417D8Rc9k3ppG?= =?Windows-1252?Q?R5WKsmlDAOIUy4hQal7jaNYePdI7NEpAyu0OR5WHy+QkD8m83OJEoNxr?= =?Windows-1252?Q?0y/IHEvnz/p0sNlM8zcCRE2DV8vAhJdDtJfmXtIJjwkozvNTQTnLLZor?= =?Windows-1252?Q?Ln26fVsFhZqCSArk2FlEsMPVVm7jvjXOCkG9UHfcBh9wf46PR+SZqI1N?= =?Windows-1252?Q?3A8VkeirDh4RSQAkHVa8GiVJL+Sn086l462AuO9equMDB3VCFmKqkOBR?= =?Windows-1252?Q?z3CA91QtBYSvJfgubQ0HgP+oZJckgog4zz4g97HDX0FsT0gOZd7m9H40?= =?Windows-1252?Q?SKJwFuea9wFGes3WjH3ygncXCpBpJXYdhfydXq72sd5dRXDZ1uW0/d0T?= =?Windows-1252?Q?Rnnu6RvLgRoq4F2J37WFU8LEkMUaj2rfdU6x37ygB/GnR2Fx/7sPO64a?= =?Windows-1252?Q?ikMd8mY4WCUZV+H1ryPZ87kPgXfYkJAS+JwRJYupIOzBLeWBkNapMG8w?= =?Windows-1252?Q?1N06yu4w39RgFTCRDbzqJ+X1BG6Km5MFTitPGATR4iy4eWzKixV01+9W?= =?Windows-1252?Q?AsN8M+1jgfA239kPXm3EvLmeu6QL+CLS9ZJbHY2mwWlZuNWI40rC+9jp?= =?Windows-1252?Q?UAC4D2oIa4cayw9Dfejted1JiXzPWEKi0dJyaV2sQL0y/ILAt8DazxTT?= =?Windows-1252?Q?PxHkNST+spHR1WJT7tTbBqQvTN4Odstw1H7oIIw3cUw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;6:Ch85pwiyQnPMJtuSqAGA6rNwVOqTuUhS+P4X1kG9Tk0T9t3jv8J5uCv+8HO3nlb1EkxfMx8Nb6i79pxFr0dTg02Pg4I0retP/yf3b7g6Zku8OSYxhVFBCnxN35NyMtKK6sHEwDkKPxJOA3sRUxxJ+sYe+LwRqQwrjult6kzN9HwmzD0o1LSKP6NYdRuatKW71wIwTVwL2Fg4MOOTuu0F0lfXDQxo0PbdZ0arcE97qP+UmRdIaV2C8raNe9cyXTNWLdFSiPSyRHQczAtT1rmGzDiNd/B96oWvxXL/g5ZZDE8DB5lLNPUPDqnWXSFwjzVOUvAAAhd0neFogp8c+toNm3EmVYlHeNq4yUBZakEfq/AhHSYwWhpQguNT/ejs9male2ce8WcVCYrxPFr/DZRUS+MnB7XJb3tdu9jVnhjNRGyOVXhcdUQG5KSLW56NSm7+5EbL4o9YrvfmcfgafOAel4BeJ/9rfitYjdW1NXkKS0OV54K8jvMtX3+OZqu9HD5h0KA+jJ+Bog3y1sm6ImaKHQ==;5:naq89YaWaCU+Ah5t+KXS2lZfyKowd9lMkaub8t9hWRPxQOoF0FB/gcAB5oVXKMYp6IJbX+EiOsKgGPU3+wh/bupDFeWxVP3aH1D/W24jHPoMvVdHY5cZFAtVIpymNUatb7SV94nrf7BrxOoq7mXBhA==;24:U1MC4oaKju9ZMpXrhyD/ESMQ/9OSn3JK26MZv+NuEDraZcspNjb0R/C+z3NzZlKxr3L2Tsu/1FCdTdIeSA+tNoBY/Ueoyymz0q1JKQRwGIA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;7:apnJS8DWw4+2VybrVaW0laqd7YpyuHmjllYHvZu9j/xSSPlkn3XrpwulGzRN6JDBISVplN9XtFIzmNDiV3Qb6VbKAcXkoJdpYe+8GlkqEz3Thm7vyXvkbxAtD6/ttNdV9SoyOy6zsOsbH1/TzY+SUJHnrDn39fY1rpKbCLCHIRcYVtxlwQOITqe7Pl4iRfSkpKa26gOOLz+D8GXtOV1GgLc9TGdSZUfoa86/66UY1Iz5OFR3V24pe7zj3RTjsXMI4JbPP1GH1UwvGkjbEqUUUEN9VtCIinhTNtNaN1J9K5CAH/plkgz8Tpn7aa4rlkvwgnCKEfFCN8aBtsvgqsJSFA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2017 21:54:00.8234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0202MB2555 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-04-18 23:53, Peter Rosin wrote: > On 2017-04-18 13:44, Greg Kroah-Hartman wrote: >> On Tue, Apr 18, 2017 at 12:59:50PM +0200, Peter Rosin wrote: >>> On 2017-04-18 10:51, Greg Kroah-Hartman wrote: >>>> On Thu, Apr 13, 2017 at 06:43:07PM +0200, Peter Rosin wrote: *snip* >>>>> + if (mux->idle_state != MUX_IDLE_AS_IS && >>>>> + mux->idle_state != mux->cached_state) >>>>> + ret = mux_control_set(mux, mux->idle_state); >>>>> + >>>>> + up_read(&mux->lock); >>>> >>>> You require a lock to be held for a "global" function? Without >>>> documentation? Or even a sparse marking? That's asking for trouble... >>> >>> Documentation I can handle, but where should I look to understand how I >>> should add sparse markings? >> >> Run sparse on the code and see what it says :) > > Will do. I just did, and even went through the trouble of getting the bleeding edge sparse from the git repo when sparse 0.5.0 came up empty, but it's all silence for me. So, how do I add sparse markings? Cheers, peda