From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH 4/4] HID: remove ThingM blink(1) driver
Date: Wed, 22 Jun 2016 21:52:47 +0200 [thread overview]
Message-ID: <0f67c7f3-45ee-9a6a-82a9-aa940a7faed9@gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1606221520340.6874@cbobk.fhfr.pm>
Am 22.06.2016 um 15:25 schrieb Jiri Kosina:
> On Tue, 21 Jun 2016, Heiner Kallweit wrote:
>
>> Now that support for ThingM blink(1) was merged into the hid-led driver
>> the dedicated driver for this device can be removed.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/hid/Kconfig | 10 --
>> drivers/hid/Makefile | 1 -
>> drivers/hid/hid-thingm.c | 259 -----------------------------------------------
>> 3 files changed, 270 deletions(-)
>> delete mode 100644 drivers/hid/hid-thingm.c
>>
>> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
>> index ab22090..6b08a3b 100644
>> --- a/drivers/hid/Kconfig
>> +++ b/drivers/hid/Kconfig
>> @@ -828,16 +828,6 @@ config HID_TOPSEED
>> Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic
>> CLLRCMCE remote control.
>>
>> -config HID_THINGM
>
> Overall the patchset looks good to me. I'd suggest we keep
> CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so
> that we don't cause kernel config regressions for users who had
> CONFIG_HID_THINGM already turned on.
>
OK
I'll add this and provide a v2 of the patch removing the old thingm driver.
> Also adding Vivien Didelot to CC, as the author of the original driver.
> Vivien, the full set can be found in linux-input archives (
> http://marc.info/?l=linux-input&r=1&b=201606&w=2 )
>
Sorry, forgot that.
prev parent reply other threads:[~2016-06-22 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f8c59082-d76c-73aa-70b6-7454b731a055@gmail.com>
2016-06-22 13:25 ` [PATCH 4/4] HID: remove ThingM blink(1) driver Jiri Kosina
2016-06-22 15:42 ` Vivien Didelot
2016-06-22 19:54 ` Heiner Kallweit
2016-06-22 20:03 ` Vivien Didelot
2016-06-22 19:52 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f67c7f3-45ee-9a6a-82a9-aa940a7faed9@gmail.com \
--to=hkallweit1@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).