From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Jon Hunter <jonathanh@nvidia.com>,
gregkh@linuxfoundation.org, m.szyprowski@samsung.com
Cc: pmenzel@molgen.mpg.de, mika.westerberg@linux.intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, krzk@kernel.org,
stable <stable@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [RFT PATCH v2] xhci: Fix memory leak when caching protocol extended capability PSI tables
Date: Fri, 14 Feb 2020 09:47:52 +0200 [thread overview]
Message-ID: <0f871a8f-aa96-4684-1d9c-a18c6edfb62f@linux.intel.com> (raw)
In-Reply-To: <f42f7f73-48e7-74ad-2524-2514f29490cb@nvidia.com>
On 13.2.2020 15.33, Jon Hunter wrote:
>
> On 11/02/2020 15:01, Mathias Nyman wrote:
>> xhci driver assumed that xHC controllers have at most one custom
>> supported speed table (PSI) for all usb 3.x ports.
>> Memory was allocated for one PSI table under the xhci hub structure.
>>
>> Turns out this is not the case, some controllers have a separate
>> "supported protocol capability" entry with a PSI table for each port.
>> This means each usb3 roothub port can in theory support different custom
>> speeds.
>>
>> To solve this, cache all supported protocol capabilities with their PSI
>> tables in an array, and add pointers to the xhci port structure so that
>> every port points to its capability entry in the array.
>>
>> When creating the SuperSpeedPlus USB Device Capability BOS descriptor
>> for the xhci USB 3.1 roothub we for now will use only data from the
>> first USB 3.1 capable protocol capability entry in the array.
>> This could be improved later, this patch focuses resolving
>> the memory leak.
>>
>> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
>> Reported-by: Sajja Venkateswara Rao <VenkateswaraRao.Sajja@amd.com>
>> Fixes: 47189098f8be ("xhci: parse xhci protocol speed ID list for usb 3.1 usage")
>> Cc: stable <stable@vger.kernel.org> # v4.4+
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>
>
> Since next-20200211, we have been observing a regression exiting suspend
> on our Tegra124 Jetson TK1 board. Bisect is pointing to this commit and
> reverting on top of -next fixes the problem.
>
> On exiting suspend, I am seeing the following ...
>
> [ 56.216793] tegra-xusb 70090000.usb: Firmware already loaded, Falcon state 0x20
> [ 56.216834] usb usb3: root hub lost power or was reset
> [ 56.216837] usb usb4: root hub lost power or was reset
> [ 56.217760] tegra-xusb 70090000.usb: No ports on the roothubs?
> [ 56.218257] tegra-xusb 70090000.usb: failed to resume XHCI: -12
> [ 56.218299] PM: dpm_run_callback(): platform_pm_resume+0x0/0x40 returns -12
> [ 56.218312] PM: Device 70090000.usb failed to resume: error -12
> [ 56.334366] hub 4-0:1.0: hub_ext_port_status failed (err = -32)
> [ 56.334368] hub 3-0:1.0: hub_ext_port_status failed (err = -32)
>
> Let me know if you have any thoughts on this.
>
> Cheers
> Jon
This was an issue with the first version, and should be fixed in the second.
next-20200211 has the faulty version,
next-20200213 is fixed, reverted first version and applied second.
Does next-20200213 work for you?
-Mathias
next prev parent reply other threads:[~2020-02-14 7:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 9:44 BUG: KASAN: use-after-free in xhci_trb_virt_to_dma.part.24+0x1c/0x80 Paul Menzel
2018-07-20 9:54 ` Greg KH
2018-07-23 11:23 ` Paul Menzel
2020-01-02 14:10 ` Paul Menzel
2020-01-03 11:04 ` Mika Westerberg
2020-01-07 12:09 ` Mathias Nyman
2020-01-07 15:35 ` Paul Menzel
2020-01-08 9:34 ` Mathias Nyman
2020-01-08 15:17 ` [RFT PATCH] xhci: Fix memory leak when caching protocol extended capability PSI tables Mathias Nyman
2020-01-08 15:40 ` Greg KH
2020-01-08 15:56 ` Mathias Nyman
[not found] ` <CGME20200211105613eucas1p27cac4202c4287a5967b2ed988779d523@eucas1p2.samsung.com>
2020-02-11 10:56 ` Marek Szyprowski
2020-02-11 12:23 ` Greg KH
2020-02-11 12:29 ` Mathias Nyman
2020-02-11 14:08 ` Mathias Nyman
2020-02-11 15:01 ` [RFT PATCH v2] " Mathias Nyman
2020-02-11 15:12 ` Marek Szyprowski
2020-02-11 16:13 ` Greg KH
2020-02-12 9:01 ` Mathias Nyman
2020-02-12 17:51 ` Greg KH
2020-02-13 13:33 ` Jon Hunter
2020-02-14 7:47 ` Mathias Nyman [this message]
2020-02-14 8:35 ` Jon Hunter
2020-01-09 8:53 ` BUG: KASAN: use-after-free in xhci_trb_virt_to_dma.part.24+0x1c/0x80 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f871a8f-aa96-4684-1d9c-a18c6edfb62f@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).