From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E20B1C432BE for ; Tue, 27 Jul 2021 00:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0D7560F93 for ; Tue, 27 Jul 2021 00:41:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234617AbhG0ABW (ORCPT ); Mon, 26 Jul 2021 20:01:22 -0400 Received: from linux.microsoft.com ([13.77.154.182]:45946 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234648AbhG0ABI (ORCPT ); Mon, 26 Jul 2021 20:01:08 -0400 Received: from [192.168.1.97] (unknown [98.4.73.180]) by linux.microsoft.com (Postfix) with ESMTPSA id 07C8620B36EA; Mon, 26 Jul 2021 17:41:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 07C8620B36EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1627346496; bh=VYyfpHSyGy1nM01Blor0Ef7JqWfZcrQIxslj4YqCez8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Lm0UttQbV31TsUfHWReHoIyDzbOju1eW/Yh8MWriNfDYgkWXnfhoi8yF3C4TXhUjD 531sAHADh05hdjguyqxmhv1AGakjZEMILV3hwfmYO1B1XOSADjGqd6Qvoxm/KizXUz iaq2SgxJ3GTVh573dlXVGabnZrj6bC+q8gYJS5YI= Subject: Re: [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is initialized To: Paolo Bonzini Cc: Dan Carpenter , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20210726165843.1441132-1-pbonzini@redhat.com> From: Vineeth Pillai Message-ID: <0f9db300-d5ec-becb-ff30-ac8ddbb62e15@linux.microsoft.com> Date: Mon, 26 Jul 2021 20:41:35 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210726165843.1441132-1-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paulo, Thanks a lot for fixing this. > > diff --git a/arch/x86/kvm/svm/svm_onhyperv.h b/arch/x86/kvm/svm/svm_onhyperv.h > index 9b9a55abc29f..c53b8bf8d013 100644 > --- a/arch/x86/kvm/svm/svm_onhyperv.h > +++ b/arch/x86/kvm/svm/svm_onhyperv.h > @@ -89,7 +89,7 @@ static inline void svm_hv_vmcb_dirty_nested_enlightenments( > * as we mark it dirty unconditionally towards end of vcpu > * init phase. > */ > - if (vmcb && vmcb_is_clean(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS) && > + if (vmcb_is_clean(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS) && > hve->hv_enlightenments_control.msr_bitmap) > vmcb_mark_dirty(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS); > } The changes looks good to me. Could you please remove the above comment as well while you are at it. Many Thanks, Vineeth