From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D32C4338F for ; Mon, 23 Aug 2021 02:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3760061378 for ; Mon, 23 Aug 2021 02:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234772AbhHWCDu (ORCPT ); Sun, 22 Aug 2021 22:03:50 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:14408 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234740AbhHWCDt (ORCPT ); Sun, 22 Aug 2021 22:03:49 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GtFm45q3KzbdNk; Mon, 23 Aug 2021 09:59:16 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 23 Aug 2021 10:02:41 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 23 Aug 2021 10:02:40 +0800 Subject: Re: [PATCH -next v2 0/3] riscv: Fix two vdso issue To: Tong Tiangen , Paul Walmsley , Palmer Dabbelt , "Palmer Dabbelt" , Albert Ou CC: , References: <20210820125042.1844629-1-tongtiangen@huawei.com> From: Kefeng Wang Message-ID: <0fa49162-18c2-0643-7495-86f2c891a285@huawei.com> Date: Mon, 23 Aug 2021 10:02:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210820125042.1844629-1-tongtiangen@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/20 20:50, Tong Tiangen wrote: > v2->v1: > Add patch "Refactor asm/vdso.h" to avoid vdso.lds syntax error if > CONFIG_GENERIC_TIME_VSYSCALL=n. This is better than v1. > > 1) Refactor the asm/vdso.h to avoid vdso.lds syntax error. > > 2) Move vdso data page up front Move  vdso data page before code page could save the problem which the .text section could be bigger than PAGE_SIZE. > and introduce enum vvar_pages, To pave the > way for the subsequent support of TIME_NS, the support of TIME_NS will be > issued in the later patch. This makes it easier to introduce new features TIME_NS. > > 3) In arch_setup_additional_pages(), make Wait for the lock in the > killable mode and return with EINTR if the task got killed while waiting. For series, Reviewed-by: Kefeng Wang > Tong Tiangen (3): > riscv/vdso: Refactor asm/vdso.h > riscv/vdso: Move vdso data page up front > riscv/vdso: make arch_setup_additional_pages wait for mmap_sem for > write killable > > arch/riscv/include/asm/syscall.h | 1 + > arch/riscv/include/asm/vdso.h | 10 ++---- > arch/riscv/kernel/syscall_table.c | 1 - > arch/riscv/kernel/vdso.c | 53 +++++++++++++++++++------------ > arch/riscv/kernel/vdso/vdso.lds.S | 3 +- > 5 files changed, 39 insertions(+), 29 deletions(-) >