From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756682AbcKBRsQ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 2 Nov 2016 13:48:16 -0400
Received: from mout.web.de ([212.227.15.3]:49233 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756600AbcKBRsO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Nov 2016 13:48:14 -0400
Subject: Re: scripts/basic/bin2c: Complete error handling in main()
To: Masahiro Yamada <yamada.masahiro@socionext.com>
References: <72e07814-56e9-505a-d660-91ff20b6efea@users.sourceforge.net>
 <44402655-ef0d-1e2f-0587-f17295a08aa3@users.sourceforge.net>
 <CAK7LNATU4VrN6wCo8vzETMJu6aX+SK+0un03ryzCg7-BW_LxqA@mail.gmail.com>
Cc: linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <0fcf5fb3-ff4a-a003-7814-51a6ab5ad988@users.sourceforge.net>
Date: Wed, 2 Nov 2016 18:48:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAK7LNATU4VrN6wCo8vzETMJu6aX+SK+0un03ryzCg7-BW_LxqA@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:6bbFztkB2m/AzIq3XeS9a6tSms9Cb3fs4v60gFs/8VAKe+voEyK
 Mpb6U8fYKTVtEwreRClxlMzqGRs2OwoHPTTmvLqRFu7TZijwaKnjdquZ/u1RXu97qEt/dec
 l+e5J9jQ+TShWoqM+Lc1W1zx6RwxtlTnqI1pFxUz114Bj3u8p/YTk+O2zjknm07UIlRFFL2
 bviZFY+k0odwhrEWKmSig==
X-UI-Out-Filterresults: notjunk:1;V01:K0:K68j1HI3LIA=:SNFoxu+kzC8E92grMHLNON
 2v+9Ts5E54qF8o5//l0U0d03JqG7aoceQTg3GXfb4OE9B7KctHWLoBscoJ0H0GtIRVBZXZFWH
 n562zGMTNvX4SAOovEX6pROR4rmUxwOb5V5AQsUInCsNh9WEIBPZ993okysK15I9f4YklUww7
 pFxGNnQ4/whvaJeUaQQtwFUfNHo6TcJABozsTlbS2NVH4RG0wmta0B8atZlw7FsIbchAVdkI9
 cyCqCmZ/5YbZlKKdUx5X1sXjvpz64ZyiLEP6ovMmXOWdep2lazE4sf8VikzwL//WVhUeDRrdM
 QlHqa11pCnxEl3z5xqcfUzGtDahVdkthc5ABS+mxy5qrZmJKafNnw0FLOit5dKh7ma4Jhmxha
 dEv0f/HYzRq4jc5OA+i4J00tOh+Wp009byAgUtZjF7i7X4WWjsn/FkUAnUNerDIpPraFmsJFy
 8w/PSBAHu3CsPINu9LzzBqKfCbq0OEDXlNJKcbRjySzA8xs79qZQtKXjRl53mz8rDmRKYZWJD
 XwKOl+fJEh+JRk64skMRMjOfPpBjx7kDr6z+zbU56shb0NkTFuruwCfPBoS1Ti4nYujnMKKtw
 +xMHgxU7VWXQvM1J2qwUA0GxrnW0VQWSQUMxPLe/69fmyBElWM34aioLyTQ5L28MSCR/OBwyO
 C5ZLjaFKaiO3oQmV/mVTYUVzrjbz/kV0dk60RC2KMLrTXOt0mL1BKoAQjQpDZ9I8M1Xo0gucv
 3bQDJ15EIoUA8lmRqWlGaT6etGKbe5lQScuBHvE+GKoQOLqTWDNigVxOXk6hHNSJEzSt1Q+ao
 9qIy7yW
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Is replacing printf("\"\n") with puts("\"") optimization?

Is the difference relevant if an “ordinary” string is passed instead of
a format string?


> Frankly, the result of this patch seems extremely unreadable code.

Do you care for more complete error detection and corresponding exception handling
in this source file?

Regards,
Markus