From: Joe Perches <joe@perches.com>
To: Shreeya Patel <shreeya.patel23498@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
sbrivio@redhat.com, daniel.baluta@gmail.com,
nramas@linux.microsoft.com, hverkuil@xs4all.nl,
Larry.Finger@lwfinger.net
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions
Date: Wed, 11 Mar 2020 10:26:29 -0700 [thread overview]
Message-ID: <0fed25f914c6f39b024dd3bbc4f11892c40f4a60.camel@perches.com> (raw)
In-Reply-To: <20200311133811.2246-1-shreeya.patel23498@gmail.com>
On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
You might consider removing the
/* Timeout value is calculated by 34 / (2^n) */
comment entirely as it doesn't make much sense.
For what N is "(34 / (2 ^ N))" = 6 ?
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
[]
> @@ -551,18 +551,11 @@ static void HalRxAggr8723BSdio(struct adapter *padapter)
>
> pregistrypriv = &padapter->registrypriv;
>
> - if (pregistrypriv->wifi_spec) {
> - /* 2010.04.27 hpfan */
> - /* Adjust RxAggrTimeout to close to zero disable RxAggr, suggested by designer */
> - /* Timeout value is calculated by 34 / (2^n) */
> - valueDMATimeout = 0x06;
> - valueDMAPageCount = 0x06;
> - } else {
> - /* 20130530, Isaac@SD1 suggest 3 kinds of parameter */
> - /* TX/RX Balance */
> - valueDMATimeout = 0x06;
> - valueDMAPageCount = 0x06;
> - }
> + /* 2010.04.27 hpfan */
> + /* Adjust RxAggrTimeout to close to zero disable RxAggr, suggested by designer */
> + /* Timeout value is calculated by 34 / (2^n) */
> + valueDMATimeout = 0x06;
> + valueDMAPageCount = 0x06;
next prev parent reply other threads:[~2020-03-11 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 13:38 [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions Shreeya Patel
2020-03-11 17:09 ` Stefano Brivio
2020-03-11 17:26 ` Joe Perches [this message]
2020-03-11 22:28 ` Shreeya Patel
2020-03-12 0:15 ` Joe Perches
2020-03-13 7:20 ` Dan Carpenter
2020-03-13 7:27 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fed25f914c6f39b024dd3bbc4f11892c40f4a60.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=sbrivio@redhat.com \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).