From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E16C4332F for ; Sun, 29 Oct 2023 21:23:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbjJ2VX6 (ORCPT ); Sun, 29 Oct 2023 17:23:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230382AbjJ2VX4 (ORCPT ); Sun, 29 Oct 2023 17:23:56 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84575D9; Sun, 29 Oct 2023 14:23:53 -0700 (PDT) Received: from [192.168.1.90] (unknown [188.24.143.101]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 679A566072BB; Sun, 29 Oct 2023 21:23:50 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698614631; bh=SGq6QPRGIBNn7gbJ2EgKHoDNWHX9rvAA0k7+HWJtVnc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=abdE6pR/zA982y8K9cNxgC1xlpp75ZzB8caxA2ixKDYqj+NQC6wKEfhwy4PQfUYyY j7WDCREK3Wzhi4Ti+raoR5XlLz7rgd52QgBzcnc0FcTl4IXNxPMCtbx+FoFLPGFche bHGVyDAabwMjuh+DsixN6oiDYSjCYYzF46mgU7MGiViIPrNQ9QzlwdPvR2AAZXOuxj BJsXPR/uB7cYb23tyMWk9rCrtc2ulZZUWUTaa7ZBHQDpjpXap2Q7DPhDaSYOZlZTLt eo+eLURddzhlIk5zq1l7hsnLgH1veVvb72E9mbnnvTfqFS41c1xEExhuYJwsOSWKIW LVkKtidAvTyrg== Message-ID: <0ff7a905-d8f2-401b-a0ff-47947d12ce05@collabora.com> Date: Sun, 29 Oct 2023 23:23:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/12] dt-bindings: net: starfive,jh7110-dwmac: Drop redundant reset description Content-Language: en-US To: Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Samin Guo , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Giuseppe Cavallaro Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20231029042712.520010-1-cristian.ciocaltea@collabora.com> <20231029042712.520010-4-cristian.ciocaltea@collabora.com> From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/23 13:19, Krzysztof Kozlowski wrote: > On 29/10/2023 05:27, Cristian Ciocaltea wrote: >> The reset description items are already provided by the referenced >> snps,dwmac.yaml schema, hence replace them with the necessary >> {min,max}Items. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> .../devicetree/bindings/net/starfive,jh7110-dwmac.yaml | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> index cc3e1c6fc135..44e58755a5a2 100644 >> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> @@ -46,9 +46,8 @@ properties: >> maxItems: 3 >> >> resets: >> - items: >> - - description: MAC Reset signal. >> - - description: AHB Reset signal. >> + minItems: 2 >> + maxItems: 2 > > You must also update reset-names. They must have same constraints. reset-names explicitly lists the items and we need to keep them as such because the order is not fixed, i.e. PATCH 1 allows using 'ahb' instead of 'stmmaceth' as the first (and only) item. reset-names: items: - const: stmmaceth - const: ahb Thanks, Cristian