bq27x00_battery status report issue

bq27x00_battery status report issue

[Grazvydas Ignotas]

Hi,

After 270968c0984ae "bq27x00_battery: Fix reporting status value for
bq27500 battery" status doesn't seem to be reported correctly when the
battery is close to fully charged state. It reports "Not charging"
while in fact there is >130mA current flowing to the battery according
to current_now.

This status report seems to be based on CHG bit in status register,
but looking at the datasheet the description says "(Fast) charging
allowed", which I guess means that the chip recommends charging and
not that charging is actually going on? If you check the bit while
battery is discharging and it's not full, the bit is also set.


-- 
Gražvydas

Re: bq27x00_battery status report issue

[Pali Rohár]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Saturday 14 January 2012 23:10:05 Grazvydas Ignotas wrote:
> Hi,
> 
> After 270968c0984ae "bq27x00_battery: Fix reporting status value for
> bq27500 battery" status doesn't seem to be reported correctly when the
> battery is close to fully charged state. It reports "Not charging"
> while in fact there is >130mA current flowing to the battery according
> to current_now.
> 
> This status report seems to be based on CHG bit in status register,
> but looking at the datasheet the description says "(Fast) charging
> allowed", which I guess means that the chip recommends charging and
> not that charging is actually going on? If you check the bit while
> battery is discharging and it's not full, the bit is also set.

Now I do not have device with bq27500 chip for testing. I read datasheet again 
and I think that your interpretation may be correct. Can you write patch for 
this problem and test it?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bq27x00_battery status report issue

[Grazvydas Ignotas]

On Thu, Jan 19, 2012 at 12:56 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> Now I do not have device with bq27500 chip for testing. I read datasheet again
> and I think that your interpretation may be correct. Can you write patch for
> this problem and test it?

What about just reverting 270968c0984ae instead? I think my patch
would look almost exactly like that..


-- 
Gražvydas

Re: bq27x00_battery status report issue

[Pali Rohár]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

On Friday 20 January 2012 13:02:46 Grazvydas Ignotas wrote:
> On Thu, Jan 19, 2012 at 12:56 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > Now I do not have device with bq27500 chip for testing. I read datasheet
> > again and I think that your interpretation may be correct. Can you write
> > patch for this problem and test it?
> 
> What about just reverting 270968c0984ae instead? I think my patch
> would look almost exactly like that..

Ok, then revert this commit.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bq27x00_battery status report issue

[Anton Vorontsov]

On Fri, Jan 20, 2012 at 02:38:08PM +0100, Pali Rohár wrote:
> On Friday 20 January 2012 13:02:46 Grazvydas Ignotas wrote:
> > On Thu, Jan 19, 2012 at 12:56 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > > Now I do not have device with bq27500 chip for testing. I read datasheet
> > > again and I think that your interpretation may be correct. Can you write
> > > patch for this problem and test it?
> > 
> > What about just reverting 270968c0984ae instead? I think my patch
> > would look almost exactly like that..
> 
> Ok, then revert this commit.

Reverted in battery-urgent.git, thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com