From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kbingham@kernel.org>
Cc: niklas.soderlund@ragnatech.se, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support
Date: Fri, 23 Jun 2017 10:43:50 +0300 [thread overview]
Message-ID: <10057741.K1MBojqRFe@avalon> (raw)
In-Reply-To: <ce388da93b793abc1b54df3e59ab287aedb9797f.1497469745.git-series.kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Wednesday 14 Jun 2017 20:58:13 Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> The Salvator boards use an ADV7482 receiver for HDMI and CVBS inputs.
>
> Provide ADV7482 node on the i2c4 bus, along with connectors for the
> hdmi and cvbs inputs, and link to the csi20 and csi40 nodes as outputs.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> v4:
> - dt: Rebase to dts/renesas/salvator-x.dtsi
> - dt: Use AIN0-7 rather than AIN1-8
>
> v5:
> - dt: Move to salvator-common.dtsi
> ---
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 123 ++++++++++++++++-
> 1 file changed, 123 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index
> aef35e0b685a..d74fb55c38bc 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -65,6 +65,27 @@
> enable-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>;
> };
>
> + cvbs-in {
> + compatible = "composite-video-connector";
> + label = "CVBS IN";
> +
> + port {
> + cvbs_con: endpoint {
> + };
> + };
> + };
> +
> + hdmi-in {
> + compatible = "hdmi-connector";
> + label = "HDMI IN";
> + type = "a";
> +
> + port {
> + hdmi_in_con: endpoint {
> + };
> + };
> + };
> +
> reg_1p8v: regulator0 {
> compatible = "regulator-fixed";
> regulator-name = "fixed-1.8V";
> @@ -257,6 +278,59 @@
> };
> };
>
> +&csi20 {
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
Aren't #address-cells, #size-cells and reg already present in the SoC .dtsi ?
And if they're not, shouldn't they be ? :-)
> + csi20_in: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1>;
> + remote-endpoint = <&adv7482_txb>;
> + };
> + };
> + };
> +};
> +
> +&csi40 {
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + csi40_in: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&adv7482_txa>;
> + };
> + };
> + };
> +};
> +
> +&cvbs_con {
> + port {
> + cvbs_in: endpoint {
> + remote-endpoint = <&adv7482_ain7>;
> + };
> + };
> +};
You could merge this with the cvbs_con node above.
Apart from that the patch looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +&hdmi_in_con {
> + port {
> + hdmi_in: endpoint {
> + remote-endpoint = <&adv7482_hdmi>;
> + };
> + };
> +};
> +
> &du {
> pinctrl-0 = <&du_pins>;
> pinctrl-names = "default";
> @@ -343,6 +417,55 @@
>
> shunt-resistor-micro-ohms = <5000>;
> };
> +
> + video-receiver@70 {
> + compatible = "adi,adv7482";
> + reg = <0x70>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + interrupt-parent = <&gpio6>;
> + interrupt-names = "intrq1", "intrq2";
> + interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
> + <31 IRQ_TYPE_LEVEL_LOW>;
> +
> + port@7 {
> + reg = <7>;
> +
> + adv7482_ain7: endpoint {
> + remote-endpoint = <&cvbs_in>;
> + };
> + };
> +
> + port@8 {
> + reg = <8>;
> +
> + adv7482_hdmi: endpoint {
> + remote-endpoint = <&hdmi_in>;
> + };
> + };
> +
> + port@10 {
> + reg = <10>;
> +
> + adv7482_txa: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csi40_in>;
> + };
> + };
> +
> + port@11 {
> + reg = <11>;
> +
> + adv7482_txb: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1>;
> + remote-endpoint = <&csi20_in>;
> + };
> + };
> + };
> };
>
> &i2c_dvfs {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-06-23 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 19:58 [PATCH v5 0/2] ADV748x HDMI/Analog video receiver Kieran Bingham
2017-06-14 19:58 ` [PATCH v5 1/2] media: i2c: adv748x: add adv748x driver Kieran Bingham
2017-06-22 21:34 ` Rob Herring
2017-06-26 11:06 ` Kieran Bingham
2017-06-14 19:58 ` [PATCH v5 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support Kieran Bingham
2017-06-23 7:43 ` Laurent Pinchart [this message]
2017-06-27 9:25 ` Kieran Bingham
2017-06-27 13:57 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10057741.K1MBojqRFe@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=kbingham@kernel.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).