From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9174CC433ED for ; Fri, 23 Apr 2021 09:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5970A613D7 for ; Fri, 23 Apr 2021 09:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241560AbhDWJBD (ORCPT ); Fri, 23 Apr 2021 05:01:03 -0400 Received: from gloria.sntech.de ([185.11.138.130]:43068 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhDWJBC (ORCPT ); Fri, 23 Apr 2021 05:01:02 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZrfg-0005L5-Nr; Fri, 23 Apr 2021 11:00:20 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: broonie@kernel.org, Jon Lin Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@esmil.dk, Jon Lin Subject: Re: [PATCH v1 2/8] spi: rockchip: add compatible string for rv1126 Date: Fri, 23 Apr 2021 11:00:18 +0200 Message-ID: <10186800.nitPUkWRp2@diego> In-Reply-To: <20210423084155.17439-2-jon.lin@rock-chips.com> References: <20210423084155.17439-1-jon.lin@rock-chips.com> <20210423084155.17439-2-jon.lin@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jon, Am Freitag, 23. April 2021, 10:41:49 CEST schrieb Jon Lin: > Add compatible string for rv1126 to applications for potential > applications. > > Signed-off-by: Jon Lin > --- > drivers/spi/spi-rockchip.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c > index 52d6259d96ed..dae0281f6ba8 100644 > --- a/drivers/spi/spi-rockchip.c > +++ b/drivers/spi/spi-rockchip.c > @@ -911,7 +911,9 @@ static const struct dev_pm_ops rockchip_spi_pm = { > }; > > static const struct of_device_id rockchip_spi_dt_match[] = { > - { .compatible = "rockchip,px30-spi", }, > + { .compatible = "rockchip,px30-spi", }, unrelated change with the add "space" at the end > + { .compatible = "rockchip,rv1108-spi", }, > + { .compatible = "rockchip,rv1126-spi", }, it seems the list was sorted alphabetically, so rv* comes after rk* which is probably why the rv1108 was at the bottom and rightfully so. Heiko > { .compatible = "rockchip,rk3036-spi", }, > { .compatible = "rockchip,rk3066-spi", }, > { .compatible = "rockchip,rk3188-spi", }, > @@ -921,7 +923,6 @@ static const struct of_device_id rockchip_spi_dt_match[] = { > { .compatible = "rockchip,rk3328-spi", }, > { .compatible = "rockchip,rk3368-spi", }, > { .compatible = "rockchip,rk3399-spi", }, > - { .compatible = "rockchip,rv1108-spi", }, > { }, > }; > MODULE_DEVICE_TABLE(of, rockchip_spi_dt_match); >