From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92095C433EF for ; Mon, 21 Mar 2022 14:15:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349232AbiCUOQi (ORCPT ); Mon, 21 Mar 2022 10:16:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351449AbiCUOLE (ORCPT ); Mon, 21 Mar 2022 10:11:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 87EE32E08D for ; Mon, 21 Mar 2022 07:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647871550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vMaQn1UtCu/LKFHSjM1uVJme2UZeiOPTmAAuYyikU+M=; b=ZjKWk5Z7QedUVITo3wigTlcyMralMRu0irKZCArEkk6j2tKr+OW/JGDmvN8dnaMR+oqAaK JcLcIWWJTtQ3vP8M6aTzvRPgf22dtL+3mtZrpkKQLpGhKkwkm6lHh/p5+ztyRMqIgqbFqh 559dGg3H8JHeATso5gEyzCqxx5be54Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-jh6NgncOPGSypXqW--5J5g-1; Mon, 21 Mar 2022 10:05:47 -0400 X-MC-Unique: jh6NgncOPGSypXqW--5J5g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B525C1C05AFF; Mon, 21 Mar 2022 14:05:46 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 942011410F35; Mon, 21 Mar 2022 14:05:44 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220316131723.111553-7-jefflexu@linux.alibaba.com> References: <20220316131723.111553-7-jefflexu@linux.alibaba.com> <20220316131723.111553-1-jefflexu@linux.alibaba.com> To: Jeffle Xu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com Subject: Re: [PATCH v5 06/22] cachefiles: implement on-demand read MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1029511.1647871543.1@warthog.procyon.org.uk> Date: Mon, 21 Mar 2022 14:05:43 +0000 Message-ID: <1029512.1647871543@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeffle Xu wrote: > + { "cread", cachefiles_ondemand_cread }, Rather than adding the cread command, would it be better to use an ioctl on the anon fd as the /dev/cachefiles write op is serialised? > + /* Stop enqueuig request when daemon closes anon_fd prematurely. */ "Enqueuing" David