From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andre Hedrick <andre@linux-ide.org>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: ide-2.4.20-pre4-ac2.patch
Date: 29 Aug 2002 23:55:41 +0100 [thread overview]
Message-ID: <1030661741.1326.7.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.10.10208271503530.24156-100000@master.linux-ide.org>
On Tue, 2002-08-27 at 23:17, Andre Hedrick wrote:
>
> This is out and has been forwarded to AC for review.
Rejected. I found several errors, a couple of strange reverts and some
files being moved to clearly wrong places. It also mixes up multiple
changes.
Andre to make this work I need
- One change per patch (within reason)
- An explanation of what it does
For example I've got files you moved and changed, looking at that in
diff is a right pita. I've got a big diff with errors in it (eg gayle in
ppc) I can't easily be sure I can cleanly drop parts of.
Lets start with the file moving. Send me a diff for the Config/Makefile
and a lit of the files to move and where. Gayle I think should be m68k
not ppc (actually Im pretty sure), CMD640 is PCI so why file it in
legacy. "legacy" I took to mean pre PCI rather than "I think its junk"
8)
next prev parent reply other threads:[~2002-08-29 22:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-27 22:17 ide-2.4.20-pre4-ac2.patch Andre Hedrick
2002-08-28 7:59 ` ide-2.4.20-pre4-ac2.patch Markus Plail
2002-08-28 9:15 ` ide-2.4.20-pre4-ac2.patch Jurriaan
2002-08-28 17:59 ` ide-2.4.20-pre4-ac2.patch Tomas Szepe
2002-08-28 18:20 ` ide-2.4.20-pre4-ac2.patch Andre Hedrick
2002-08-28 18:26 ` ide-2.4.20-pre4-ac2.patch Tomas Szepe
2002-08-28 18:28 ` ide-2.4.20-pre4-ac2.patch Andre Hedrick
2002-08-28 18:31 ` ide-2.4.20-pre4-ac2.patch Tomas Szepe
2002-08-28 20:41 ` ide-2.4.20-pre4-ac2.patch Tomas Szepe
2002-08-28 20:49 ` ide-2.4.20-pre4-ac2.patch Alan Cox
2002-08-29 22:55 ` Alan Cox [this message]
2002-08-29 23:16 ` ide-2.4.20-pre4-ac2.patch Roman Zippel
2002-08-29 23:21 ` ide-2.4.20-pre4-ac2.patch Alan Cox
2002-08-29 23:43 ` ide-2.4.20-pre4-ac2.patch Roman Zippel
2002-08-30 9:43 ` ide-2.4.20-pre4-ac2.patch Benjamin Herrenschmidt
2002-08-30 1:01 ` ide-2.4.20-pre4-ac2.patch Daniel Egger
2002-08-30 7:36 ` ide-2.4.20-pre4-ac2.patch Roman Zippel
2002-08-30 3:36 ` ide-2.4.20-pre4-ac2.patch Andre Hedrick
2002-08-30 9:40 ` ide-2.4.20-pre4-ac2.patch Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030661741.1326.7.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).