linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Stevenson <james@stev.org>
To: Philippe Troin <phil@fifi.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.19: oops in ide-scsi
Date: 25 Sep 2002 19:18:15 +0100	[thread overview]
Message-ID: <1032977895.1676.0.camel@god.stev.org> (raw)
In-Reply-To: <87adm6kofe.fsf@ceramic.fifi.org>

Hi

then i belive there are other possible problems which may by
just as bad

On Wed, 2002-09-25 at 17:46, Philippe Troin wrote:
> James Stevenson <james@stev.org> writes:
> 
> > On Tue, 2002-09-24 at 22:00, Philippe Troin wrote:
> > > James Stevenson <james@stev.org> writes:
> > > 
> > > > Hi
> > > > 
> > > > i am glad somebody else sees the same crash as me the
> > > > request Q gets set to NULL for some reson then tries to
> > > > increment a stats counter in the null pointer.
> > > > i know what the bug is i just dont know how to fix it :>
> > > 
> > > I'm not sure which Q you're talking about.
> > > Is that rq (in idescsi_pc_intr())?
> > 
> > the crash happens on
> > 
> > if (status & ERR_STAT)
> > 	rq->errors++;
> > 
> > because 
> > struct request *rq = pc->rq;
> > is NULL
> 
> Have you tried changing it to:
> 
>         if (status & ERR_STAT && rq)
>         	rq->errors++;
> 
> The code is going to return anyways, and rq is only used here on this
> path.
> 
> BTW, can you reproduce the oops at will? I can't :-(
> 
> Phil.



  reply	other threads:[~2002-09-25 18:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-24  1:08 Philippe Troin
2002-09-24 18:26 ` James Stevenson
2002-09-24 21:00   ` Philippe Troin
2002-09-24 21:41     ` James Stevenson
2002-09-25 16:46       ` Philippe Troin
2002-09-25 18:18         ` James Stevenson [this message]
2002-09-25 22:30           ` Philippe Troin
2002-09-26  8:51             ` James Stevenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1032977895.1676.0.camel@god.stev.org \
    --to=james@stev.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phil@fifi.org \
    --subject='Re: 2.4.19: oops in ide-scsi' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).