From: Alan Cox <firstname.lastname@example.org> To: John Levon <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Linus Torvalds <email@example.com> Subject: Re: [PATCH][RFC] oprofile 2.5.38 patch Date: 26 Sep 2002 17:08:29 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20020923222933.GA33523@compsoc.man.ac.uk> Ok comments Security: enable_write with a count of 0xFFFFFFFF again repeated everywhere Major The buffer_read function doesnt seem to be SMP safe Doesnt seem to know about Intel pmc errata Assumes it will get PM notifiers reliably (it wont) Minor Massive duplication of code in each read/write handler - build some helpers which actually do the thing right and you'd also have less bugs cpu_type_read doesnt handle partial read cpu_type_read scribbles on more data than the user requested (fun to feed as stdin to a setuid app) similar errors permeate the rest of that code Trivial In the event of an -EFAULT data is lost (nothing illegal about it) Basically its a nice prototype, but with the prototype working could do with some auditing and a cleanup. I think if you replace all the read/write functions with some clean helpers and fix the messes in the helpers it'll clean up really nicely
next prev parent reply other threads:[~2002-09-26 16:00 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2002-09-23 22:29 John Levon 2002-09-24 18:48 ` Christoph Hellwig 2002-09-24 12:23 ` John Levon 2002-09-26 16:08 ` Alan Cox [this message] [not found] <20020923222933.GA33523@compsoc.man.ac.uk.suse.lists.linux.kernel> 2002-09-24 12:43 ` Andi Kleen 2002-09-24 12:55 ` John Levon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH][RFC] oprofile 2.5.38 patch' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).