archive mirror
 help / color / mirror / Atom feed
From: Robert Love <>
To: Tim Schmielau <>
Cc: John Levon <>,
	Arnaldo Carvalho de Melo <>,
	lkml <>
Subject: Re: [PATCH] break out task_struct from sched.h
Date: 29 Sep 2002 17:06:29 -0400	[thread overview]
Message-ID: <1033333589.22056.1381.camel@phantasy> (raw)
In-Reply-To: <>

On Sun, 2002-09-29 at 17:00, Tim Schmielau wrote:

> You're right.
> I had the vague hope that by separating type definitions only
> some future cleanup might help us to cut down on the number of
> headers included by task_struct.h (currently 60).
> Introducing a full-blown task.h looks like killing sched.h completely

I like this: introduce a tasks.h to separate the task_struct and any
helper macros that depend on it.

We can keep sched.h though - but just for scheduler stuff from sched.c. 
We need a place to put the prototypes, inlines, and defines from sched.c
and sched.h is the cleanest place.

It is the other stuff (task_struct most importantly, as you point out)
that needs to go.

> Killing ~600 #include <linux/sched.h> lines however seemed enough for a 
> first round, so I left this for later iterations.

Indeed, good job.

	Robert Love

  reply	other threads:[~2002-09-29 21:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-29 19:50 [PATCH] break out task_struct from sched.h Tim Schmielau
2002-09-29 20:13 ` John Levon
2002-09-29 21:00   ` Tim Schmielau
2002-09-29 21:06     ` Robert Love [this message]
2002-09-29 22:17       ` Dave Jones
2002-09-29 22:23         ` Arnaldo Carvalho de Melo
2002-09-30  7:34         ` Tim Schmielau
2002-09-30 12:17 ` Arnd Bergmann
2002-09-30 22:57   ` Tim Schmielau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1033333589.22056.1381.camel@phantasy \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).