From: Robert Love <rml@tech9.net>
To: Andrew Morton <akpm@digeo.com>
Cc: Dave Hansen <haveblue@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: 2.5.40-mm2
Date: 06 Oct 2002 18:23:40 -0400 [thread overview]
Message-ID: <1033943021.27093.29.camel@phantasy> (raw)
In-Reply-To: <3DA0B422.C23B23D4@digeo.com>
On Sun, 2002-10-06 at 18:07, Andrew Morton wrote:
> > - while (base->running_timer == timer) {
> > + while (base->running_timer == timer)
> > cpu_relax();
> > - preempt_disable();
> > - preempt_enable();
I am confused as to why Ingo would put these here. He knows very well
what he is doing... surely he had a reason.
If he intended to force a preemption point here, then the lines needs to
be reversed. This assumes, of course, preemption is disabled here. But
I do not think it is.
If he just wanted to check for preemption, we have a
preempt_check_resched() which does just that (I even think he wrote
it). Note as long as interrupts are enabled this probably does not
achieve much anyhow.
So I do not know. I find it odd the solution is to completely remove
it...
Btw, I think the solution to the crash is to add a check to
cpu_online().
Robert Love
next prev parent reply other threads:[~2002-10-06 22:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-06 18:47 2.5.40-mm2 Andrew Morton
2002-10-06 20:47 ` 2.5.40-mm2 Dave Hansen
2002-10-06 21:55 ` 2.5.40-mm2 Andrew Morton
2002-10-06 22:07 ` 2.5.40-mm2 Andrew Morton
2002-10-06 22:11 ` 2.5.40-mm2 Andrew Morton
2002-10-07 5:46 ` 2.5.40-mm2 Dave Hansen
2002-10-06 22:23 ` Robert Love [this message]
2002-10-06 22:33 ` 2.5.40-mm2 Andrew Morton
2002-10-06 22:38 ` 2.5.40-mm2 Robert Love
2002-10-08 11:05 ` 2.5.40-mm2 Ingo Molnar
2002-10-08 16:23 ` 2.5.40-mm2 Dave Hansen
2002-10-08 16:43 ` 2.5.40-mm2 Dave Hansen
2002-10-08 16:56 ` 2.5.40-mm2 Andrew Morton
2002-10-09 8:12 ` 2.5.40-mm2 Ingo Molnar
2002-10-07 17:45 ` 2.5.40-mm2 Badari Pulavarty
2002-10-07 17:55 ` 2.5.40-mm2 Jens Axboe
2002-10-07 18:23 ` 2.5.40-mm2 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1033943021.27093.29.camel@phantasy \
--to=rml@tech9.net \
--cc=akpm@digeo.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).