From: Mark Haverkamp <markh@osdl.org>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.42] aacraid code changes
Date: 14 Oct 2002 14:32:46 -0700 [thread overview]
Message-ID: <1034631166.23163.5.camel@markh1.pdx.osdl.net> (raw)
In-Reply-To: <1034619906.5419.34.camel@markh1.pdx.osdl.net>
I found a source for the rq_dev element elsewhere in the Scsi_Cmnd
structure. This patch contains a replacement for the one I sent
earlier.
Mark.
diff -Nru base_linux-2.5/drivers/scsi/aacraid/aachba.c linux-2.5/drivers/scsi/aacraid/aachba.c
--- base_linux-2.5/drivers/scsi/aacraid/aachba.c Mon Oct 7 13:03:15 2002
+++ linux-2.5/drivers/scsi/aacraid/aachba.c Mon Oct 14 14:24:16 2002
@@ -1060,7 +1060,8 @@
*/
spin_unlock_irq(scsicmd->host->host_lock);
- fsa_dev_ptr->devno[cid] = DEVICE_NR(scsicmd->sc_request->sr_request->rq_dev);
+ fsa_dev_ptr->devno[cid] =
+ DEVICE_NR(scsicmd->request->rq_dev);
ret = aac_read(scsicmd, cid);
spin_lock_irq(scsicmd->host->host_lock);
return ret;
diff -Nru base_linux-2.5/drivers/scsi/aacraid/commctrl.c linux-2.5/drivers/scsi/aacraid/commctrl.c
--- base_linux-2.5/drivers/scsi/aacraid/commctrl.c Mon Oct 7 13:03:15 2002
+++ linux-2.5/drivers/scsi/aacraid/commctrl.c Mon Oct 14 10:35:04 2002
@@ -424,7 +424,12 @@
status = aac_get_pci_info(dev,arg);
break;
default:
- status = -ENOTTY;
+ /*
+ * Return EINVAL instead of ENOTTY because blkdev_ioctl
+ * understands the EINVAL return code to mean that the
+ * ioctl wasn't handled and blk_ioctl should be called.
+ */
+ status = -EINVAL;
break;
}
return status;
prev parent reply other threads:[~2002-10-14 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-14 18:25 [PATCH 2.5.42] aacraid code changes Mark Haverkamp
2002-10-14 21:32 ` Mark Haverkamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1034631166.23163.5.camel@markh1.pdx.osdl.net \
--to=markh@osdl.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).