From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Nicolas Pitre <nico@cam.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] small tty irq race fix
Date: 03 Mar 2003 20:06:06 +0000 [thread overview]
Message-ID: <1046721965.7320.9.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0303031305130.31566-100000@xanadu.home>
> fp = tty->flip.flag_buf + TTY_FLIPBUF_SIZE;
> - tty->flip.buf_num = 0;
>
> local_irq_save(flags); // FIXME: is this safe?
> + tty->flip.buf_num = 0;
The other CPU can be touching these fields too surely. Its a
useful note that the spinlocks need putting in the right spot
but its still broken 8(
next prev parent reply other threads:[~2003-03-03 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-03 18:09 [patch] small tty irq race fix Nicolas Pitre
2003-03-03 20:06 ` Alan Cox [this message]
2003-03-03 19:15 ` Nicolas Pitre
2003-03-03 21:20 ` Nicolas Pitre
2003-03-03 21:39 ` Linus Torvalds
2003-03-03 21:51 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1046721965.7320.9.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@cam.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).