From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dave Jones <davej@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.5.64
Date: 06 Mar 2003 01:06:37 +0000 [thread overview]
Message-ID: <1046912796.15950.27.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20030305181927.C20788@suse.de>
On Wed, 2003-03-05 at 17:19, Dave Jones wrote:
> On Wed, Mar 05, 2003 at 02:36:09PM +0000, Christoph Hellwig wrote:
> > > o [WATCHDOG] Remove old unneeded borken module locking
> >
> > You just removed the nowayout functionality..
>
> Only the bits that did the module locking crap, which
> is unnecessary afaics. If you look at the files touched,
> there's still nowayout used in the other functions.
You need to lock the module in memory in the nowayout case
Otherwise the module can be unloaded (which is ok), and then
reloaded (which is not).
So yes, you broke NOWAYOUT. Its a bit subtle and under
documented I admit.
next prev parent reply other threads:[~2003-03-05 23:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-05 3:48 Linux 2.5.64 Linus Torvalds
2003-03-05 14:36 ` Christoph Hellwig
2003-03-05 17:19 ` Dave Jones
2003-03-06 1:06 ` Alan Cox [this message]
2003-03-06 0:42 ` Dave Jones
2003-03-05 19:53 ` 2.5.64: cpufreq "userspace" governor doesn't compile Adrian Bunk
2003-03-06 17:28 ` Russell King
2003-03-06 17:16 ` Patrick Mochel
2003-03-06 23:31 ` [PATCH] cpufreq (2/7): fix userspace governor [Was: Re: 2.5.64: cpufreq "userspace" governor doesn't compile] Dominik Brodowski
2003-03-05 22:13 ` [2.5 patch] remove EXPORT_NO_SYMBOLS from amd7xx_tco Adrian Bunk
2003-03-05 23:57 ` Dave Jones
2003-03-05 23:49 ` Linux 2.5.64 John Cherry
2003-03-06 10:39 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1046912796.15950.27.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davej@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).