From: Antonino Daplas <adaplas@pol.net>
To: James Simmons <jsimmons@infradead.org>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [Linux-fbdev-devel] Re: FBdev updates.
Date: 06 Mar 2003 09:18:29 +0800 [thread overview]
Message-ID: <1046913418.1206.189.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.44.0303052023110.27760-100000@phoenix.infradead.org>
On Thu, 2003-03-06 at 04:23, James Simmons wrote:
>
> > > And one (or two...) generic questions: why is not pseudo_palette
> > > u32* pseudo_palette, or even directly u32 pseudo_palette[17] ?
> >
> > Yes, all drivers should treat the pseudo_palette as u32* anyway, so why
> > not change pseudo-palette from void* to u32*?
>
> See other email.
>
> > > And why we do not fill this pseudo_palette with
> > > i * 0x01010101U for 8bpp pseudocolor and i * 0x11111111U for 4bpp
> > > pseudocolor? This allowed me to remove couple of switches and tests
> > > from acceleration fastpaths (and from cfb_imageblit and cfb_fillrect,
> > > but I did not changed these two in my benchmarks below).
> >
> > I also agree for a different reason. Cards with unconventional formats
> > (such as monochrome at 8 bpp - 0 for black , 0xff for white) will not
> > work with the current code.
>
> Isn't that the job of setcolreg?
>
setcolreg does that for directcolor and truecolor modes, because they're
the only ones that uses the pseudo_palette. See all driver codes, the
pseudo_palette is never initialized if in pseudo_color.
The purpose of the pseudo_palette is to enable to write pixels to the
framebuffer without knowing the color format at all. So, if you have
monochrome, then black is 0 and white is 1. But for monochrome 8bpp,
black is 0 and white is 0xff.
fbcon will send 0's and 1's, thus 0 and 1 will be written to the
framebuffer. If the drawing functions referred to the pseudo_palette,
whatever the visual format, then 0 and 0xff will be written, as it
should be.
Tony
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger
> for complex code. Debugging C/C++ programs can leave you feeling lost and
> disoriented. TotalView can help you find your way. Available on major UNIX
> and Linux platforms. Try it free. www.etnus.com
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
next prev parent reply other threads:[~2003-03-06 1:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-20 1:09 FBdev updates James Simmons
2003-02-20 1:17 ` Jeff Garzik
2003-02-20 1:22 ` James Simmons
2003-02-20 15:02 ` Dave Jones
2003-02-20 15:07 ` James Simmons
2003-02-20 18:29 ` Petr Vandrovec
2003-02-20 19:03 ` Jurriaan
2003-02-20 19:58 ` James Simmons
2003-02-20 22:00 ` [Linux-fbdev-devel] " Antonino Daplas
2003-02-21 9:09 ` Geert Uytterhoeven
2003-02-21 10:46 ` Antonino Daplas
2003-02-21 11:02 ` Geert Uytterhoeven
2003-02-21 1:45 ` David S. Miller
2003-02-21 9:04 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2003-02-21 0:24 ` Antonino Daplas
2003-03-03 20:35 ` Petr Vandrovec
2003-03-03 21:25 ` Geert Uytterhoeven
2003-03-03 21:32 ` Antonino Daplas
2003-03-05 20:23 ` James Simmons
2003-03-06 1:18 ` Antonino Daplas [this message]
2003-03-04 21:29 ` Jurriaan
2003-03-04 21:46 ` Petr Vandrovec
2003-03-09 21:29 ` Petr Vandrovec
2003-03-09 22:27 ` Antonino Daplas
2003-03-09 22:54 ` Petr Vandrovec
2003-03-09 23:44 ` Antonino Daplas
2003-03-11 15:31 ` James Simmons
2003-03-05 20:22 ` James Simmons
2003-03-06 7:35 ` Sven Luther
2003-03-06 8:05 ` Antonino Daplas
2003-03-06 8:25 ` Sven Luther
2003-03-28 14:19 ` 2.5.66 fbdev performance (was Re: Re: FBdev updates) Petr Vandrovec
2003-03-28 18:50 ` [Linux-fbdev-devel] " Antonino Daplas
2003-02-20 15:10 ` FBdev updates Ivan Kokshaysky
-- strict thread matches above, loose matches on Subject: below --
2003-03-05 20:31 [Linux-fbdev-devel] " Petr Vandrovec
2003-03-04 21:53 Petr Vandrovec
2002-06-05 16:50 fbdev updates Russell King
2002-06-05 17:21 ` [Linux-fbdev-devel] " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1046913418.1206.189.camel@localhost.localdomain \
--to=adaplas@pol.net \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).