From: Norbert Kiesel <nkiesel@tbdnetworks.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Ulrich Drepper <drepper@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Multiple & vs. && and | vs. || bugs in 2.4.20
Date: 07 Mar 2003 10:45:52 -0800 [thread overview]
Message-ID: <1047062752.30853.135.camel@defiant> (raw)
In-Reply-To: <20030306195812.GH2781@zaurus.ucw.cz>
Hi,
Alan included my 2.4.20 patches - including the one for acm.c - in
2.4.21-pre5-ac1, so I expect them to show up in mainline someday. Still
working on delivering some of the 2.5.x ones...
--nk
On Thu, 2003-03-06 at 11:58, Pavel Machek wrote:
> Hi!
>
> > >
> > > - if (!urb->status & !acm->throttle) {
> > > + if (!urb->status && !acm->throttle) {
> > > for (i = 0; i < urb->actual_length && !acm->throttle; i++) {
>
> > To summarize, I'd probably not be amused if you would change any of my
> > code which takes advantage of such programming finess. I would probably
> > have added appropriate comments to explain the code but nevertheless,
> > replacing the more efficient code with some which is easier to
> > understand should probably be considered on a case by case basis.
>
> Actually I feel co-responsible for acm.c,
> and this *is* typo. acm is for modems,
> thats *not* performance critical, and certainly
> not worth code obfuscation.
--
Norbert Kiesel <nkiesel@tbdnetworks.com>
TBD Networks
prev parent reply other threads:[~2003-03-07 18:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-02 12:14 [PATCH] Multiple & vs. && and | vs. || bugs in 2.4.20 Norbert Kiesel
2003-03-02 18:05 ` Ulrich Drepper
2003-03-02 18:25 ` Roman Zippel
2003-03-02 21:41 ` Werner Almesberger
2003-03-02 22:03 ` Richard Henderson
2003-03-03 2:03 ` Norbert Kiesel
2003-03-03 3:02 ` John Levon
2003-03-06 19:58 ` Pavel Machek
2003-03-07 18:45 ` Norbert Kiesel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1047062752.30853.135.camel@defiant \
--to=nkiesel@tbdnetworks.com \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).