From: Arjan van de Ven <arjanv@redhat.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.4+ptrace exploit fix breaks root's ability to strace
Date: 22 Mar 2003 16:28:05 +0100 [thread overview]
Message-ID: <1048346885.1708.2.camel@laptop.fenrus.com> (raw)
In-Reply-To: <20030322141006.A8159@flint.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
> --- orig/kernel/ptrace.c Wed Mar 19 15:54:45 2003
> +++ linux/kernel/ptrace.c Sat Mar 22 10:14:01 2003
> @@ -22,7 +22,7 @@
> int ptrace_check_attach(struct task_struct *child, int kill)
> {
> mb();
> - if (!is_dumpable(child))
> + if (!is_dumpable(child) && !(child->ptrace & PT_PTRACE_CAP))
> return -EPERM;
>
> if (!(child->ptrace & PT_PTRACED))
this sounds really wrong; the child says it doesn't want to be ptraced
and now you allow it anyway. I think the problem is more that the child
isn't dumpable.... checking why
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-03-22 15:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-22 10:31 2.4+ptrace exploit fix breaks root's ability to strace Russell King
2003-03-22 14:58 ` Alan Cox
2003-03-22 14:10 ` Russell King
2003-03-22 15:28 ` Arjan van de Ven [this message]
2003-03-22 17:13 ` Russell King
2003-03-22 17:28 ` Arjan van de Ven
2003-03-22 19:09 ` Alan Cox
2003-03-22 18:01 ` Russell King
2003-03-23 10:31 ` Lists (lst)
2003-03-23 10:38 ` Russell King
2003-03-23 11:11 ` Martin Loschwitz
2003-03-23 10:43 ` Arjan van de Ven
2003-04-17 5:46 Yusuf Wilajati Purna
2003-04-19 5:57 ` Bernhard Kaindl
2003-04-22 5:03 ` Yusuf Wilajati Purna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1048346885.1708.2.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).