linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stefan Riedmüller" <S.Riedmueller@phytec.de>
To: "laurent.pinchart@ideasonboard.com"  <laurent.pinchart@ideasonboard.com>
Cc: "mchehab@kernel.org" <mchehab@kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v3 3/6] dt-bindings: media: mt9p031: Add missing required properties
Date: Mon, 5 Jul 2021 15:00:53 +0000	[thread overview]
Message-ID: <104e925e7b13d358a30d19fddf0211dceef3b349.camel@phytec.de> (raw)
In-Reply-To: <YN8RWoy0xryBw3bL@pendragon.ideasonboard.com>

Hi Laurent,

On Fri, 2021-07-02 at 16:15 +0300, Laurent Pinchart wrote:
> Hi Stefan,
> 
> Thank you for the patch.
> 
> On Fri, Jul 02, 2021 at 11:59:19AM +0200, Stefan Riedmueller wrote:
> > Add missing required clocks and supply regulator properties for the
> > sensor input clock and vdd, vdd_io and vaa supply regulators.
> 
> Can I volunteer you to convert these bindings to YAML first, and add the
> properties on top ? :-)

Sure, I can give it a try :-)

Regards,
Stefan

> 
> > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> > ---
> >  .../devicetree/bindings/media/i2c/mt9p031.txt        | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > index cb60443ff78f..4437d0e3147d 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > @@ -9,6 +9,12 @@ Required Properties:
> >  	(a) "aptina,mt9p031" for mt9p031 sensor
> >  	(b) "aptina,mt9p031m" for mt9p031m sensor
> >  
> > +- clocks: Reference to the sensor input clock
> > +
> > +- vdd-supply: VDD supply regulator
> > +- vdd_io-supply: VDD_IO supply regulator
> > +- vaa-supply: VAA supply regulator
> > +
> >  - input-clock-frequency: Input clock frequency.
> >  
> >  - pixel-clock-frequency: Pixel clock frequency.
> > @@ -29,6 +35,12 @@ Example:
> >  			reg = <0x5d>;
> >  			reset-gpios = <&gpio3 30 0>;
> >  
> > +			clocks = <&sensor_clk>;
> > +
> > +			vdd-supply = <&reg_vdd>;
> > +			vdd_io-supply = <&reg_vdd_io>;
> > +			vaa-supply = <&reg_vaa>;
> > +
> >  			port {
> >  				mt9p031_1: endpoint {
> >  					input-clock-frequency = <6000000>;

  reply	other threads:[~2021-07-05 15:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02  9:59 [PATCH v3 0/6] media: mt9p031: Read back the real clock rate Stefan Riedmueller
2021-07-02  9:59 ` [PATCH v3 1/6] " Stefan Riedmueller
2021-07-05  7:13   ` Sakari Ailus
2021-07-05  7:42     ` Stefan Riedmüller
2021-07-02  9:59 ` [PATCH v3 2/6] media: mt9p031: Make pixel clock polarity configurable by DT Stefan Riedmueller
2021-07-02  9:59 ` [PATCH v3 3/6] dt-bindings: media: mt9p031: Add missing required properties Stefan Riedmueller
2021-07-02 13:15   ` Laurent Pinchart
2021-07-05 15:00     ` Stefan Riedmüller [this message]
2021-07-02  9:59 ` [PATCH v3 4/6] dt-bindings: media: mt9p031: add pclk-sample property Stefan Riedmueller
2021-07-02  9:59 ` [PATCH v3 5/6] media: mt9p031: Fix corrupted frame after restarting stream Stefan Riedmueller
2021-07-02  9:59 ` [PATCH v3 6/6] media: mt9p031: Use BIT macro Stefan Riedmueller
2021-07-02 13:13   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=104e925e7b13d358a30d19fddf0211dceef3b349.camel@phytec.de \
    --to=s.riedmueller@phytec.de \
    --cc=devicetree@vger.kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).