linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@redhat.com>
To: mikem@beardog.cca.cpqcorp.net
Cc: axboe@suse.de, linux-kernel@vger.kernel.org, mike.miller@hp.com,
	steve.cameron@hp.com
Subject: Re: RE:cciss patches for 2.4.21-rc1, 4 of 4
Date: 25 Apr 2003 16:04:33 +0200	[thread overview]
Message-ID: <1051279472.1391.15.camel@laptop.fenrus.com> (raw)
In-Reply-To: <200304242212.h3OMCgc01143@beardog.cca.cpqcorp.net>

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

On Fri, 2003-04-25 at 00:12, mikem@beardog.cca.cpqcorp.net wrote:
> 20030424
> 
> Changes:
> 	1. Sets the DMA mask to 64 bits. Removes RH's code for the DMA mask.
> 
> diff -urN lx2421rc1-p3/drivers/block/cciss.c lx2421rc1/drivers/block/cciss.c
> --- lx2421rc1-p3/drivers/block/cciss.c	Wed Apr 23 14:40:48 2003
> +++ lx2421rc1/drivers/block/cciss.c	Wed Apr 23 14:51:55 2003
> @@ -106,7 +106,7 @@
>  #define NR_CMDS		 128 /* #commands that can be outstanding */
>  #define MAX_CTLR 8
>  
> -#define CCISS_DMA_MASK	0xFFFFFFFF	/* 32 bit DMA */
> +#define CCISS_DMA_MASK 0xFFFFFFFFFFFFFFFF /* 64 bit DMA */
>  
>  static ctlr_info_t *hba[MAX_CTLR];
>  
> @@ -2861,17 +2861,6 @@
>  	hba[i]->ctlr = i;
>  	hba[i]->pdev = pdev;
>  
> -	/* configure PCI DMA stuff */
> -	if (!pci_set_dma_mask(pdev, (u64) 0xffffffffffffffff))
> -		printk("cciss: using DAC cycles\n");
> -	else if (!pci_set_dma_mask(pdev, (u64) 0xffffffff))
> -		printk("cciss: not using DAC cycles\n");
> -	else {
> -		printk("cciss: no suitable DMA available\n");
> -		free_hba(i);
> -		return -ENODEV;
> -	}
> -		


this is wrong. The code there is EXACTLY what is needed as per
Documentation/DMA-mapping.txt, removing it is a bug.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2003-04-25 13:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-24 22:12 RE:cciss patches for 2.4.21-rc1, 4 of 4 mikem
2003-04-25 14:04 ` Arjan van de Ven [this message]
2003-04-25 14:32   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1051279472.1391.15.camel@laptop.fenrus.com \
    --to=arjanv@redhat.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=mikem@beardog.cca.cpqcorp.net \
    --cc=steve.cameron@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).