Re: Merge with DRI CVS tree: remove stale old context switching code and

Re: Merge with DRI CVS tree: remove stale old context switching code and

[Arjan van de Ven]

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

On Sat, 2003-04-26 at 00:58, Linux Kernel Mailing List wrote:

>  
>  void *DRM(realloc)(void *oldpt, size_t oldsize, size_t size, int area)
>  {
>  	void *pt;
>  
> -	if (!(pt = DRM(alloc)(size, area))) return NULL;
> +	if (!(pt = kmalloc(size, GFP_KERNEL))) return NULL;
>  	if (oldpt && oldsize) {
>  		memcpy(pt, oldpt, oldsize);
> -		DRM(free)(oldpt, oldsize, area);
> +		kfree(oldpt);
>  	}
>  	return pt;
>  }

this looks like buggy code, if you use realloc to shrink the allocation
the memcpy overwrites random memory.




[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]