Re:[2.5] Update sk98lin driver

Re:[2.5] Update sk98lin driver

[Xose Vazquez Perez]

Martin Schlemmer wrote:

>I have a 3Com 3c940 gigabit LOM, that is basically a
>SysKonnect chipset card. Here are later drivers that
>do support it:
>
> ftp://ftp.asus.com.tw/pub/ASUS/lan/3com/3c940/041_Linux.zip

latest drivers for SK-98xx and clones are 6.05 version.
patch for 2.4.20: http://www.syskonnect.de/syskonnect/support/driver/zip/sk98lin_2.4.20_patch.gz

regards,
-- 
Galiza nin perdoa nin esquence. Governo demision!

Re: Re:[2.5] Update sk98lin driver

[Martin Schlemmer]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Sun, 2003-05-04 at 23:30, Xose Vazquez Perez wrote:
> Martin Schlemmer wrote:
> 
> >I have a 3Com 3c940 gigabit LOM, that is basically a
> >SysKonnect chipset card. Here are later drivers that
> >do support it:
> >
> > ftp://ftp.asus.com.tw/pub/ASUS/lan/3com/3c940/041_Linux.zip
> 
> latest drivers for SK-98xx and clones are 6.05 version.
> patch for 2.4.20: http://www.syskonnect.de/syskonnect/support/driver/zip/sk98lin_2.4.20_patch.gz
> 

Ok, I updated it to 6.05, and can be found here:

  ftp://ftp.puk.ac.za/incoming/sk98lin-update-2.5.68.patch.bz2

A few issues though:

1)  Should MOD_INC_USE_COUNT and MOD_DEC_USE_COUNT just be removed?
    I commented them for now.

2)  What other changes should be done for 2.5 ?


Thanks,

-- 

Martin Schlemmer
Gentoo Linux Developer, Desktop/System Team Developer
Cape Town, South Africa



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Re:[2.5] Update sk98lin driver

[David S. Miller]

On Sun, 2003-05-04 at 16:56, Martin Schlemmer wrote:
> A few issues though:
> 
> 1)  Should MOD_INC_USE_COUNT and MOD_DEC_USE_COUNT just be removed?
>     I commented them for now.

No.  For the net device itself, make sure you do
SET_MODULE_OWNER() on the netdev before passing it
to register_netdevice().

For the procfs stuff you must make sure the appropriate
module refcounting is done for that mechanism.

Just deleteing MOD_{INC,DEC}_USE_COUNT blindly will result
in the module being broken.

-- 
David S. Miller <davem@redhat.com>