linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt_Domsch@Dell.com
To: greg@kroah.com, mochel@osdl.org
Cc: alan@redhat.com, linux-kernel@vger.kernel.org, jgarzik@redhat.com
Subject: Re: [RFC][PATCH] Dynamic PCI Device IDs
Date: Mon, 5 May 2003 21:04:35 -0500	[thread overview]
Message-ID: <1052186678.19726.9.camel@iguana.localdomain> (raw)

> I like this patch a _lot_ better, nice job.

Thanks.

>   Only one comment:
> > +        if (error < 0)
> > +                return error;
> > +        return count;
> > +
> > +
> > +     return count;
> > +}
> 
> Oops, lost the tabs at the end of the function :)

Duh.  Good eyes.  Fixed.

> This function will not link up a device to a driver properly within
> the driver core, only with the pci code.  So if you do this, the
> driver core still thinks you have a device that is unbound, right? 
> Also, the symlinks don't get created from the bus to the device I
> think, correct?

I think you're right.

> Unfortunatly, looking at the driver core real quickly, I don't see a
> simple way to kick the probe cycle off again for all pci devices, but
> I'm probably just missing something somewhere...

I think drivers/base/bus.c: driver_attach() is what we want, which will
walk the list of the bus's devices and run bus_match() which is
pci_bus_match() which will scan for us.  Just need to un-static
driver_attach() I expect.  Pat, does this sound right?

If that works, probe_each_pci_dev() can go away.  I'll play with it some
more.

Thanks,
Matt
-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer, Architect
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com



             reply	other threads:[~2003-05-06  1:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-06  2:04 Matt_Domsch [this message]
2003-05-06  3:56 ` Greg KH
2003-05-06 16:35   ` Matt Domsch
2003-05-10  0:11     ` Greg KH
2003-05-13 21:28     ` Patrick Mochel
2003-05-13 21:33       ` Patrick Mochel
  -- strict thread matches above, loose matches on Subject: below --
2003-05-01  0:39 Matt_Domsch
2003-05-02 23:15 ` Greg KH
2003-05-05  5:37   ` Jeff Garzik
2003-05-06  0:17     ` Greg KH
2003-05-05 22:51   ` Matt Domsch
2003-05-06  0:15     ` Greg KH
2003-04-30 21:45 Matt Domsch
2003-04-30 21:53 ` Jeff Garzik
2003-04-30 22:24 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1052186678.19726.9.camel@iguana.localdomain \
    --to=matt_domsch@dell.com \
    --cc=alan@redhat.com \
    --cc=greg@kroah.com \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    --subject='Re: [RFC][PATCH] Dynamic PCI Device IDs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).