From: "Michel Dänzer" <michel@daenzer.net>
To: davidm@hpl.hp.com
Cc: Dave Jones <davej@codemonkey.org.uk>,
linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net
Subject: Re: [Dri-devel] Re: Improved DRM support for cant_use_aperture platforms
Date: 12 May 2003 21:48:31 +0200 [thread overview]
Message-ID: <1052768911.10752.268.camel@thor> (raw)
In-Reply-To: <16063.60859.712283.537570@napali.hpl.hp.com>
On Mon, 2003-05-12 at 20:53, David Mosberger wrote:
> >>>>> On 11 May 2003 23:55:33 +0200, Michel Dänzer <michel@daenzer.net> said:
>
> >> OK, we have a chicken & egg problem then: I could obviously add
> >> Linux kernel version checks where needed, but to do that, the
> >> patch first needs to go into the kernel.
>
> Michel> Mind elaborating on that? I don't see such a problem as you
> Michel> don't need version checks for anything the patch itself
> Michel> adds, only for kernel infrastructure that isn't available in
> Michel> older kernels (down to 2.4).
>
> OK, I'm confused then: earlier on, you reported this error:
>
> asm/agp.h: No such file or directory
>
> My patch adds the following to asm-i386/agp.h:
>
> diff -Nru a/include/asm-i386/agp.h b/include/asm-i386/agp.h
> --- a/include/asm-i386/agp.h Sat May 10 01:47:42 2003
> +++ b/include/asm-i386/agp.h Sat May 10 01:47:42 2003
> @@ -20,4 +20,11 @@
> worth it. Would need a page for it. */
> #define flush_agp_cache() asm volatile("wbinvd":::"memory")
>
> +/*
> + * Page-protection value to be used for AGP memory mapped into kernel space. For
> + * platforms which use coherent AGP DMA, this can be PAGE_KERNEL. For others, it needs to
> + * be an uncached mapping (such as write-combining).
> + */
> +#define PAGE_AGP PAGE_KERNEL_NOCACHE
> +
> #endif
>
> So, either you're using a platform which I don't know supports AGP, or
> the patch didn't apply cleanly (perhaps because you're using an old
> kernel that doesn't have asm/agp.h yet?).
That's it. So we have to check the version before #including
<asm/agp.h>. Then, we can do something like
#ifndef PAGE_AGP
#define PAGE_AGP PAGE_KERNEL_NOCACHE
#endif
Or am I missing something?
This is the easy part though, you probably know better than I what to do
about the functions you use that aren't available in 2.4 yet. :)
--
Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer
Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer
next prev parent reply other threads:[~2003-05-12 19:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-10 10:09 Improved DRM support for cant_use_aperture platforms David Mosberger
2003-05-10 13:12 ` Dave Jones
2003-05-11 11:43 ` Michel Dänzer
2003-05-11 18:09 ` David Mosberger
2003-05-11 19:55 ` Dave Jones
2003-05-11 21:55 ` Michel Dänzer
2003-05-12 18:53 ` David Mosberger
2003-05-12 19:48 ` Michel Dänzer [this message]
2003-05-12 20:19 ` [Dri-devel] " David Mosberger
2003-05-12 21:21 ` Michel Dänzer
2003-05-12 21:51 ` David Mosberger
2003-05-12 21:57 ` Christoph Hellwig
2003-05-12 22:08 ` Andrew Morton
2003-05-12 22:20 ` Christoph Hellwig
2003-05-13 0:34 ` Michel Dänzer
2003-05-13 1:09 ` David Mosberger
2003-05-13 13:33 ` Ivan Kokshaysky
2003-05-13 16:20 ` David Mosberger
2003-05-14 9:41 ` Ivan Kokshaysky
2003-05-14 10:27 ` Michel Dänzer
2003-05-14 17:09 ` David Mosberger
2003-05-13 7:43 ` David Mosberger
2003-05-14 14:08 ` Michel Dänzer
2003-05-15 15:59 ` David Mosberger
2003-05-15 22:37 ` Michel Dänzer
2003-05-16 23:50 ` [Dri-devel] " Michel Dänzer
2003-05-12 20:40 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1052768911.10752.268.camel@thor \
--to=michel@daenzer.net \
--cc=davej@codemonkey.org.uk \
--cc=davidm@hpl.hp.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).