From: Guo Zhi <qtxuning1999@sjtu.edu.cn>
To: Joe Perches <joe@perches.com>
Cc: Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi scsi_transport_iscsi.c: fix misuse of %llu in scsi_transport_iscsi.c
Date: Sat, 9 Oct 2021 12:35:17 +0800 (CST) [thread overview]
Message-ID: <1054322431.5783331.1633754117686.JavaMail.zimbra@sjtu.edu.cn> (raw)
In-Reply-To: <5daf69b365e23ceecee911c4d0f2f66a0b9ec95c.camel@perches.com>
I will send a V2 patch.
----- 原始邮件 -----
发件人: "Joe Perches" <joe@perches.com>
收件人: "Guo Zhi" <qtxuning1999@sjtu.edu.cn>, "Lee Duncan" <lduncan@suse.com>, "Chris Leech" <cleech@redhat.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>
抄送: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, "linux-kernel" <linux-kernel@vger.kernel.org>
发送时间: 星期六, 2021年 10 月 09日 上午 11:14:36
主题: Re: [PATCH] scsi scsi_transport_iscsi.c: fix misuse of %llu in scsi_transport_iscsi.c
On Sat, 2021-10-09 at 11:02 +0800, Guo Zhi wrote:
> Pointers should be printed with %p or %px rather than
> cast to (unsigned long long) and printed with %llu.
> Change %llu to %p to print the pointer into sysfs.
][]
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
[]
> @@ -129,8 +129,8 @@ show_transport_handle(struct device *dev, struct device_attribute *attr,
>
>
> if (!capable(CAP_SYS_ADMIN))
> return -EACCES;
> - return sysfs_emit(buf, "%llu\n",
> - (unsigned long long)iscsi_handle(priv->iscsi_transport));
> + return sysfs_emit(buf, "%p\n",
> + iscsi_ptr(priv->iscsi_transport));
iscsi_transport is a pointer isn't it?
so why not just
return sysfs_emit(buf, "%p\n", priv->iscsi_transport);
?
next prev parent reply other threads:[~2021-10-09 4:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 3:02 [PATCH] scsi scsi_transport_iscsi.c: fix misuse of %llu in scsi_transport_iscsi.c Guo Zhi
2021-10-09 3:14 ` Joe Perches
2021-10-09 4:35 ` Guo Zhi [this message]
2021-10-11 6:35 ` Antw: [EXT] " Ulrich Windl
2021-10-11 15:29 ` Mike Christie
2021-10-12 7:04 ` Ulrich Windl
2021-10-15 7:36 ` Guo Zhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1054322431.5783331.1633754117686.JavaMail.zimbra@sjtu.edu.cn \
--to=qtxuning1999@sjtu.edu.cn \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=joe@perches.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).