From: James Bottomley <James.Bottomley@steeleye.com>
To: Andrew Morton <akpm@digeo.com>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: 2.5.73-mm1 falling over in SDET
Date: 28 Jun 2003 22:28:57 -0500 [thread overview]
Message-ID: <1056857338.2514.4.camel@mulgrave> (raw)
In-Reply-To: <20030628170235.51ee2f69.akpm@digeo.com>
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
On Sat, 2003-06-28 at 19:02, Andrew Morton wrote:
> Yes, isplinux_queuecommand() returns non-zero and the scsi generic layer
> cheerfully goes infinitely recursive.
Sigh, certain persons need to be more careful when doing logic
alterations.
Try the attached.
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain, Size: 448 bytes --]
===== drivers/scsi/hosts.c 1.79 vs edited =====
--- 1.79/drivers/scsi/hosts.c Thu Jun 26 22:51:24 2003
+++ edited/drivers/scsi/hosts.c Sat Jun 28 22:14:12 2003
@@ -194,7 +194,7 @@
shost->use_blk_tcq = sht->use_blk_tcq;
shost->highmem_io = sht->highmem_io;
- if (!sht->max_host_blocked)
+ if (sht->max_host_blocked)
shost->max_host_blocked = sht->max_host_blocked;
else
shost->max_host_blocked = SCSI_DEFAULT_HOST_BLOCKED;
next prev parent reply other threads:[~2003-06-29 3:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-28 14:31 2.5.73-mm1 falling over in SDET Martin J. Bligh
2003-06-28 15:36 ` Martin J. Bligh
2003-06-29 0:02 ` Andrew Morton
2003-06-29 3:28 ` James Bottomley [this message]
2003-06-29 5:35 ` Martin J. Bligh
2003-06-30 10:17 ` Maneesh Soni
2003-06-30 13:04 ` Maneesh Soni
2003-06-30 18:19 ` Andrew Morton
2003-06-28 17:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1056857338.2514.4.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).