From: David Woodhouse <dwmw2@infradead.org>
To: Richard Curnow <Richard.Curnow@superh.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mundt <lethal@linux-sh.org>,
Ben Gaster <Benedict.Gaster@superh.com>,
Sean McGoogan <sean.mcgoogan@superh.com>,
Boyd Moffat <boyd.moffat@superh.com>
Subject: Re: NFS structure allocation alignment patch
Date: Thu, 10 Jul 2003 12:05:21 +0100 [thread overview]
Message-ID: <1057835121.21073.208.camel@passion.cambridge.redhat.com> (raw)
In-Reply-To: <20030630135233.GN5586@malvern.uk.w2k.superh.com>
On Mon, 2003-06-30 at 14:52, Richard Curnow wrote:
> Hi Trond, Marcelo,
>
> Below is a patch against 2.4.21 to tidy up the allocation of two
> structures in nfs3_proc_unlink_setup. We need this change for NFS to
> work on the sh64 architecture, which has just been merged into 2.4 in
> the last couple of days. Otherwise, 'res' is 4-byte aligned but not
> necessarily 8-byte aligned, but struct nfs_attr contains fields that are
> 8 bytes wide. This leads to alignment exceptions on loads and stores
> into that structure.
What's wrong with alignment exceptions? They get fixed up by your
exception handler, surely?
If you assert that it's a performance-critical path and hence we
shouldn't be relying on the exception fixup, that's fine -- but in that
case it's not a correctness fix, it's just an optimisation.
--
dwmw2
next prev parent reply other threads:[~2003-07-10 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-30 13:52 NFS structure allocation alignment patch Richard Curnow
2003-07-10 11:05 ` David Woodhouse [this message]
2003-07-16 15:03 ` Richard Curnow
2003-07-18 16:10 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1057835121.21073.208.camel@passion.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=Benedict.Gaster@superh.com \
--cc=Richard.Curnow@superh.com \
--cc=boyd.moffat@superh.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=sean.mcgoogan@superh.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).