* Linux 2.4.22-pre5
@ 2003-07-11 20:26 Marcelo Tosatti
[not found] ` <shsu19siyru.fsf@charged.uio.no>
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Marcelo Tosatti @ 2003-07-11 20:26 UTC (permalink / raw)
To: lkml
Hi,
Here goes -pre5.
It fixes a deadlock introduced by the IO fairness changes, fixes ACPI on
IBM's x440, has an uptodated cciss driver, a new ethernet driver for IBM
PPC's 4xx, amongst other fixes.
Please help testing.
Summary of changes from v2.4.22-pre4 to v2.4.22-pre5
============================================
<jcchen:icplus.com.tw>:
o [netdrvr sundance] increase eeprom read timeout
<mike.miller:hp.com>:
o cciss: change names and correct subsystem device ID for U320
o cciss: PCI BAR fix
o cciss: Fix potential overrun
o cciss: update version
o cciss: First part of PCI changes/driver cleanup
o cciss: Second part of PCI changes/driver cleanup
Andi Kleen:
o Fix compiling on x86-64
Benjamin Herrenschmidt:
o radeonfb 0.1.8 + my stuffs
Chris Mason:
o Fix deadlocks in IO scheduler changes
David Woodhouse:
o Backport vsprintf/scanf fixes from 2.5.74
Geert Uytterhoeven:
o Fix adbhid m68k screwup
J. A. Magallon:
o hfsplus: group Apple FS's and help text
John Stultz:
o Fix boot crash of x440's in full acpi mode
o Cleanup x440 acpi fix
Marcelo Tosatti:
o Changed EXTRAVERSION to -pre5
Petr Vandrovec:
o Fix matroxfb on PPC64
Tom Rini:
o An ethernet driver for the IBM PPC 4xx series of machines
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
[not found] ` <shsu19siyru.fsf@charged.uio.no>
@ 2003-07-11 20:54 ` Marcelo Tosatti
2003-07-11 21:09 ` Trond Myklebust
0 siblings, 1 reply; 14+ messages in thread
From: Marcelo Tosatti @ 2003-07-11 20:54 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Jeff Garzik, Alan Cox, Christoph Hellwig, lkml
On Fri, 11 Jul 2003, Trond Myklebust wrote:
>
> Is there still any chance for the NFS O_DIRECT support to make it?
Yes.
I guess the best way of doing so would be adding ->direct_io2 and
KERNEL24_HAS_ODIRECT_2 define.
Correct?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-11 20:54 ` Marcelo Tosatti
@ 2003-07-11 21:09 ` Trond Myklebust
2003-07-11 21:18 ` Jeff Garzik
2003-07-11 21:56 ` Marcelo Tosatti
0 siblings, 2 replies; 14+ messages in thread
From: Trond Myklebust @ 2003-07-11 21:09 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Jeff Garzik, Alan Cox, Christoph Hellwig, lkml
>>>>> " " == Marcelo Tosatti <marcelo@conectiva.com.br> writes:
>> Is there still any chance for the NFS O_DIRECT support to make
>> it?
> I guess the best way of doing so would be adding ->direct_io2
> and KERNEL24_HAS_ODIRECT_2 define.
That is what the last patch I sent you does (also sent to l-k). Should
I resend?
Cheers,
Trond
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-11 21:09 ` Trond Myklebust
@ 2003-07-11 21:18 ` Jeff Garzik
2003-07-11 21:56 ` Marcelo Tosatti
1 sibling, 0 replies; 14+ messages in thread
From: Jeff Garzik @ 2003-07-11 21:18 UTC (permalink / raw)
To: trond.myklebust; +Cc: Marcelo Tosatti, Alan Cox, Christoph Hellwig, lkml
Trond Myklebust wrote:
>>>>>>" " == Marcelo Tosatti <marcelo@conectiva.com.br> writes:
>
>
> >> Is there still any chance for the NFS O_DIRECT support to make
> >> it?
>
> > I guess the best way of doing so would be adding ->direct_io2
> > and KERNEL24_HAS_ODIRECT_2 define.
IMO, yes.
> That is what the last patch I sent you does (also sent to l-k). Should
> I resend?
Sounds like it :)
Christoph, opinion?
Jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-11 21:09 ` Trond Myklebust
2003-07-11 21:18 ` Jeff Garzik
@ 2003-07-11 21:56 ` Marcelo Tosatti
2003-07-11 22:07 ` Jeff Garzik
2003-07-12 6:27 ` Christoph Hellwig
1 sibling, 2 replies; 14+ messages in thread
From: Marcelo Tosatti @ 2003-07-11 21:56 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Jeff Garzik, Alan Cox, Christoph Hellwig, lkml
On Fri, 11 Jul 2003, Trond Myklebust wrote:
> >>>>> " " == Marcelo Tosatti <marcelo@conectiva.com.br> writes:
>
> >> Is there still any chance for the NFS O_DIRECT support to make
> >> it?
>
> > I guess the best way of doing so would be adding ->direct_io2
> > and KERNEL24_HAS_ODIRECT_2 define.
>
> That is what the last patch I sent you does (also sent to l-k). Should
No, no need to resend. I have it.
I released -pre5 so quickly because of the IO hang fix, which is pretty
important. (Christoph: your vmap patch will go on -pre6 too once I read
it).
Well, Jeff, Christoph, do you have any comments on Trond's new
O_DIRECT patch?
I haven't looked at it closely, yet.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-11 21:56 ` Marcelo Tosatti
@ 2003-07-11 22:07 ` Jeff Garzik
2003-07-12 6:27 ` Christoph Hellwig
1 sibling, 0 replies; 14+ messages in thread
From: Jeff Garzik @ 2003-07-11 22:07 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Trond Myklebust, Alan Cox, Christoph Hellwig, lkml
Marcelo Tosatti wrote:
> Well, Jeff, Christoph, do you have any comments on Trond's new
> O_DIRECT patch?
I looked at it, and it looked ok to me. Basically I was wondering was
Christoph thought at this point...
Jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-11 20:26 Linux 2.4.22-pre5 Marcelo Tosatti
[not found] ` <shsu19siyru.fsf@charged.uio.no>
@ 2003-07-11 22:22 ` Richard A Nelson
2003-07-11 22:38 ` Marcelo Tosatti
2003-07-12 1:59 ` Linux 2.4.22-pre5 - unresolved in hfsplus Eyal Lebedinsky
2 siblings, 1 reply; 14+ messages in thread
From: Richard A Nelson @ 2003-07-11 22:22 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
On Fri, 11 Jul 2003, Marcelo Tosatti wrote:
> Here goes -pre5.
[...]
>
> Benjamin Herrenschmidt:
> o radeonfb 0.1.8 + my stuffs
radeonfb.c:168:28: linux/radeonfb.h: No such file or directory
--
Rick Nelson
I still maintain the point that designing a monolithic kernel in 1991 is a
fundamental error. Be thankful you are not my student. You would not get a
high grade for such a design :-)
(Andrew Tanenbaum to Linus Torvalds)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-11 22:22 ` Richard A Nelson
@ 2003-07-11 22:38 ` Marcelo Tosatti
2003-07-14 16:32 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 14+ messages in thread
From: Marcelo Tosatti @ 2003-07-11 22:38 UTC (permalink / raw)
To: Richard A Nelson; +Cc: lkml, benh
Ben?
On Fri, 11 Jul 2003, Richard A Nelson wrote:
> On Fri, 11 Jul 2003, Marcelo Tosatti wrote:
>
> > Here goes -pre5.
> [...]
> >
> > Benjamin Herrenschmidt:
> > o radeonfb 0.1.8 + my stuffs
>
> radeonfb.c:168:28: linux/radeonfb.h: No such file or directory
>
> --
> Rick Nelson
> I still maintain the point that designing a monolithic kernel in 1991 is a
> fundamental error. Be thankful you are not my student. You would not get a
> high grade for such a design :-)
> (Andrew Tanenbaum to Linus Torvalds)
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5 - unresolved in hfsplus
2003-07-11 20:26 Linux 2.4.22-pre5 Marcelo Tosatti
[not found] ` <shsu19siyru.fsf@charged.uio.no>
2003-07-11 22:22 ` Richard A Nelson
@ 2003-07-12 1:59 ` Eyal Lebedinsky
2003-07-12 8:29 ` J.A. Magallon
2 siblings, 1 reply; 14+ messages in thread
From: Eyal Lebedinsky @ 2003-07-12 1:59 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
Marcelo Tosatti wrote:
> Here goes -pre5.
> J. A. Magallon:
> o hfsplus: group Apple FS's and help text
depmod: *** Unresolved symbols in
/lib/modules/2.4.22-pre5/kernel/fs/hfsplus/hfsplus.o
depmod: mark_page_accessed
--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-11 21:56 ` Marcelo Tosatti
2003-07-11 22:07 ` Jeff Garzik
@ 2003-07-12 6:27 ` Christoph Hellwig
2003-07-12 6:50 ` Trond Myklebust
1 sibling, 1 reply; 14+ messages in thread
From: Christoph Hellwig @ 2003-07-12 6:27 UTC (permalink / raw)
To: Marcelo Tosatti
Cc: Trond Myklebust, Jeff Garzik, Alan Cox, Christoph Hellwig, lkml
On Fri, Jul 11, 2003 at 06:56:16PM -0300, Marcelo Tosatti wrote:
> Well, Jeff, Christoph, do you have any comments on Trond's new
> O_DIRECT patch?
Patch looks fine. I don't really like the directfileio name, but
hey, this cludge is so ugly that it doesn't really matter anymore..
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-12 6:27 ` Christoph Hellwig
@ 2003-07-12 6:50 ` Trond Myklebust
0 siblings, 0 replies; 14+ messages in thread
From: Trond Myklebust @ 2003-07-12 6:50 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Marcelo Tosatti, Trond Myklebust, Jeff Garzik, Alan Cox, lkml
>>>>> " " == Christoph Hellwig <hch@infradead.org> writes:
> Patch looks fine. I don't really like the directfileio name,
Feel free to suggest a better one. I chose it 'cos I hate the idea of
version numbers on function names (i.e. direct_iO2).
> but hey, this cludge is so ugly that it doesn't really matter
> anymore..
Agreed...
cheers,
Trond
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5 - unresolved in hfsplus
2003-07-12 1:59 ` Linux 2.4.22-pre5 - unresolved in hfsplus Eyal Lebedinsky
@ 2003-07-12 8:29 ` J.A. Magallon
2003-07-12 10:50 ` Eyal Lebedinsky
0 siblings, 1 reply; 14+ messages in thread
From: J.A. Magallon @ 2003-07-12 8:29 UTC (permalink / raw)
To: Eyal Lebedinsky; +Cc: Marcelo Tosatti, lkml
On 07.12, Eyal Lebedinsky wrote:
> Marcelo Tosatti wrote:
> > Here goes -pre5.
> > J. A. Magallon:
> > o hfsplus: group Apple FS's and help text
>
> depmod: *** Unresolved symbols in
> /lib/modules/2.4.22-pre5/kernel/fs/hfsplus/hfsplus.o
> depmod: mark_page_accessed
>
I did not touch the code, I suppose nobody has tried to build it as a module.
Try with this...
--- mm/filemap.c.orig 2003-07-12 10:24:55.000000000 +0200
+++ mm/filemap.c 2003-07-12 10:25:17.000000000 +0200
@@ -1338,6 +1338,8 @@
SetPageReferenced(page);
}
+EXPORT_SYMBOL(mark_page_accessed);
+
/*
* This is a generic file read routine, and uses the
* inode->i_op->readpage() function for the actual low-level
--
J.A. Magallon <jamagallon@able.es> \ Software is like sex:
werewolf.able.es \ It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.22-pre2-jam1 (gcc 3.3 (Mandrake Linux 9.2 3.3-2mdk))
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5 - unresolved in hfsplus
2003-07-12 8:29 ` J.A. Magallon
@ 2003-07-12 10:50 ` Eyal Lebedinsky
0 siblings, 0 replies; 14+ messages in thread
From: Eyal Lebedinsky @ 2003-07-12 10:50 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
"J.A. Magallon" wrote:
>
> On 07.12, Eyal Lebedinsky wrote:
> > Marcelo Tosatti wrote:
> > > Here goes -pre5.
> > > J. A. Magallon:
> > > o hfsplus: group Apple FS's and help text
> >
> > depmod: *** Unresolved symbols in
> > /lib/modules/2.4.22-pre5/kernel/fs/hfsplus/hfsplus.o
> > depmod: mark_page_accessed
> >
>
> I did not touch the code, I suppose nobody has tried to build it as a module.
Something was touched since I did not have this problem with the
2.4.21-ac
series which included hfsplus. This problem arrived with 2.4.22-pre3
(when hfsplus was introduced) so there was some merge issue maybe?
Actually, diffing .22-pre3-ac1 and .22-pre3 shows a few more fixes with
operator precedence missing in -pre3, like
- if (!file->f_flags & O_DIRECT)
+ if (!(file->f_flags & O_DIRECT))
Which I am sure must be fixed.
--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Linux 2.4.22-pre5
2003-07-11 22:38 ` Marcelo Tosatti
@ 2003-07-14 16:32 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 14+ messages in thread
From: Benjamin Herrenschmidt @ 2003-07-14 16:32 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Richard A Nelson, lkml
On Sat, 2003-07-12 at 00:38, Marcelo Tosatti wrote:
> Ben?
bk fuckage on my side, here it is
#ifndef __LINUX_RADEONFB_H__
#define __LINUX_RADEONFB_H__
#include <asm/ioctl.h>
#include <asm/types.h>
#define ATY_RADEON_LCD_ON 0x00000001
#define ATY_RADEON_CRT_ON 0x00000002
#define FBIO_RADEON_GET_MIRROR _IOR('@', 3, __u32)
#define FBIO_RADEON_SET_MIRROR _IOW('@', 4, __u32)
#endif
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2003-07-14 16:18 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-11 20:26 Linux 2.4.22-pre5 Marcelo Tosatti
[not found] ` <shsu19siyru.fsf@charged.uio.no>
2003-07-11 20:54 ` Marcelo Tosatti
2003-07-11 21:09 ` Trond Myklebust
2003-07-11 21:18 ` Jeff Garzik
2003-07-11 21:56 ` Marcelo Tosatti
2003-07-11 22:07 ` Jeff Garzik
2003-07-12 6:27 ` Christoph Hellwig
2003-07-12 6:50 ` Trond Myklebust
2003-07-11 22:22 ` Richard A Nelson
2003-07-11 22:38 ` Marcelo Tosatti
2003-07-14 16:32 ` Benjamin Herrenschmidt
2003-07-12 1:59 ` Linux 2.4.22-pre5 - unresolved in hfsplus Eyal Lebedinsky
2003-07-12 8:29 ` J.A. Magallon
2003-07-12 10:50 ` Eyal Lebedinsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).