From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Roberto Sanchez <rcsanchez97@yahoo.es>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jsimmons@infradead.org, geert@linux-m68k.org, torvalds@osdl.org
Subject: Re: [PATCH] drivers/video/vesafb.c, kernel 2.6.0-test1
Date: 20 Jul 2003 13:21:39 +0100 [thread overview]
Message-ID: <1058703699.32239.4.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <20030720021133.53368.qmail@web41804.mail.yahoo.com>
On Sul, 2003-07-20 at 03:11, Roberto Sanchez wrote:
> --- linux-2.6.0-test1.orig/drivers/video/vesafb.c 2003-07-13
> 23:30:36.000000000 -0400
> +++ linux/drivers/video/vesafb.c 2003-07-19 20:30:18.000000000 -0400
> @@ -227,7 +227,7 @@
> vesafb_defined.xres = screen_info.lfb_width;
> vesafb_defined.yres = screen_info.lfb_height;
> vesafb_fix.line_length = screen_info.lfb_linelength;
> - vesafb_fix.smem_len = screen_info.lfb_size * 65536;
> + vesafb_fix.smem_len = screen_info.lfb_width * screen_info.lfb_height *
> screen_info.lfb_depth;
> vesafb_fix.visual = (vesafb_defined.bits_per_pixel == 8) ?
> FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_TRUECOLOR;
This will make some systems crash on boot.
width * height * depth is in bits. You tben need to chop that down to
bytes and maybe allow room for the scroll buffer, but only if its still
under the size of the entire frame buffer.
See the final 2.4 changes
prev parent reply other threads:[~2003-07-20 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-20 2:11 [PATCH] drivers/video/vesafb.c, kernel 2.6.0-test1 Roberto Sanchez
2003-07-20 12:21 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1058703699.32239.4.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=geert@linux-m68k.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rcsanchez97@yahoo.es \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).