From: David Woodhouse <dwmw2@infradead.org>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: ffrederick@prov-liege.be, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Washing suspend code
Date: Mon, 21 Jul 2003 03:55:30 +0100 [thread overview]
Message-ID: <1058727060.1091.2.camel@lapdancer.baythorne.internal> (raw)
In-Reply-To: <20030702131047.GA9779@suse.de>
On Wed, 2003-07-02 at 14:10, Dave Jones wrote:
> On Wed, Jul 02, 2003 at 10:43:11AM +0200, ffrederick@prov-liege.be wrote:
> > }
> > +int touchable_process (struct task_struct *p)
> > +{
> > + return(!((p->flags & PF_IOTHREAD) || (p == current) || (p->state == TASK_ZOMBIE)))
> > +
> > +}
>
> *horror*. Please keep the formatting of the original macro.
> It's a) more readable, and b) Documentation/CodingStyle compliant.
Bugger the formatting. The original macro invocation 'INTERESTING(p)'
may invoke 'continue;' and change the flow of execution in an utterly
unobvious manner. The 'if (something) continue;' form is _definitely_
better.
--
dwmw2
prev parent reply other threads:[~2003-07-21 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 8:43 [PATCH] Washing suspend code ffrederick
2003-07-02 13:10 ` Dave Jones
2003-07-21 2:55 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1058727060.1091.2.camel@lapdancer.baythorne.internal \
--to=dwmw2@infradead.org \
--cc=davej@codemonkey.org.uk \
--cc=ffrederick@prov-liege.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).