linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Jürgen Stohr" <juergen.stohr@gmx.de>
Cc: Andre Hedrick <andre@linux-ide.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: BUG in pdc202xx_old.c
Date: 21 Jul 2003 00:31:05 +0100	[thread overview]
Message-ID: <1058743864.32464.5.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <200307202206.21872.juergen.stohr@gmx.de>

On Sul, 2003-07-20 at 21:06, Jürgen Stohr wrote:
>                          * check to make sure drive on same channel
>                          * is u66 capable
>                          */
> -                       if (hwif->drives[!(drive->dn%2)].id) {
> +                       if (hwif->drives[!(drive->dn%2)].present) {

This doesn't really seem to make sense for current IDE - drive[n].id is
never NULL. On old systems it was and this test was needed so we didnt
check ultra dma flags on an ident free drive (old ST506 etc)

That makes me curious as to what is really going on here.


      parent reply	other threads:[~2003-07-20 23:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-20 20:06 BUG in pdc202xx_old.c Jürgen Stohr
2003-07-20 20:53 ` Andre Hedrick
2003-07-20 23:31 ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1058743864.32464.5.camel@dhcp22.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=andre@linux-ide.org \
    --cc=juergen.stohr@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).