From: Steven Cole <elenstev@mesatop.com>
To: "Diego Calleja García" <diegocg@teleline.es>
Cc: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
Christoph Hellwig <hch@infradead.org>,
tcfelker@mtco.com, linux-kernel@vger.kernel.org,
Daniel McNeil <daniel@osdl.org>
Subject: Re: root= needs hex in 2.6.0-test1-mm2
Date: 23 Jul 2003 13:30:00 -0600 [thread overview]
Message-ID: <1058988599.1675.115.camel@spc9.esa.lanl.gov> (raw)
In-Reply-To: <20030723201737.27c8fce9.diegocg@teleline.es>
On Wed, 2003-07-23 at 12:17, Diego Calleja García wrote:
> El 23 Jul 2003 17:08:31 +0200 Felipe Alfaro Solana <felipe_alfaro@linuxmail.org> escribió:
>
> > I didn't compile devfs in... However, root=/dev/xxx caused a panic
> > during bootup. So, I guess those panics aren't related exclusively to
> > devfs.
>
> I can confirm this. It happens without devfsd.
> The hex trick worked ;)
In case you missed it, Daniel McNeil posted this patch here:
http://marc.theaimsgroup.com/?l=linux-kernel&m=105898580610066&w=2
For some odd reason, that mail didn't show up in my lkml box,
but I grabbed his patch from the above, and it had some weird mailer
mangling in the archive, but nothing difficult to fix.
The patch works for me. Now I can boot 2.6.0-test1-mm2 with
root=/dev/hda1 and no hex tricks.
Here is Daniel's patch.
Steven
--- linux-2.6.0-test1-mm2/init/do_mounts.c.orig 2003-07-23 12:52:21.000000000 -0600
+++ linux-2.6.0-test1-mm2/init/do_mounts.c 2003-07-23 13:04:32.000000000 -0600
@@ -58,6 +58,7 @@
char *s;
int len;
int fd;
+ unsigned int maj, min;
/* read device number from .../dev */
@@ -70,8 +71,12 @@
if (len <= 0 || len == 32 || buf[len - 1] != '\n')
goto fail;
buf[len - 1] = '\0';
- res = (dev_t) simple_strtoul(buf, &s, 16);
- if (*s)
+ /*
+ * The format of dev is now %u:%u -- see print_dev_t()
+ */
+ if (sscanf(buf, "%u:%u", &maj, &min) == 2)
+ res = MKDEV(maj, min);
+ else
goto fail;
/* if it's there and we are not looking for a partition - that's it */
next prev parent reply other threads:[~2003-07-23 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-23 6:56 root= needs hex in 2.6.0-test1-mm2 Tom Felker
2003-07-23 12:20 ` Felipe Alfaro Solana
2003-07-23 15:06 ` Florian Huber
2003-07-23 15:48 ` Charles Lepple
2003-07-23 13:43 ` Christoph Hellwig
2003-07-23 15:08 ` Felipe Alfaro Solana
2003-07-23 18:17 ` Diego Calleja García
2003-07-23 19:30 ` Steven Cole [this message]
2003-07-23 15:33 ` Con Kolivas
2003-07-23 18:52 ` Tom Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1058988599.1675.115.camel@spc9.esa.lanl.gov \
--to=elenstev@mesatop.com \
--cc=daniel@osdl.org \
--cc=diegocg@teleline.es \
--cc=felipe_alfaro@linuxmail.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tcfelker@mtco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).