linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>
To: Apurva Mehta <apurva@gmx.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Random Oopses on 2.6.0-test1-mm2
Date: Sat, 26 Jul 2003 10:54:10 +0200	[thread overview]
Message-ID: <1059209649.577.4.camel@teapot.felipe-alfaro.com> (raw)
In-Reply-To: <20030726071801.GB1358@home.woodlands>

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

On Sat, 2003-07-26 at 09:18, Apurva Mehta wrote:
> Hi, 
> 
> I get random oopses while using 2.6.0-test1-mm2. I have attached the
> oops message and also the ksymoops output. I get the same behaviour
> with the 08int patch applied also. The OOPs message attached was
> obtained on a 2.6.0-test1-mm2-08int.

Please, try the following patch...

[-- Attachment #2: ext3-inode.patch --]
[-- Type: text/x-patch, Size: 1115 bytes --]

diff -puN fs/ext3/inode.c~ext3_getblk-race-fix-fix fs/ext3/inode.c
--- 25/fs/ext3/inode.c~ext3_getblk-race-fix-fix	2003-07-19 22:59:50.000000000 -0700
+++ 25-akpm/fs/ext3/inode.c	2003-07-19 23:07:42.000000000 -0700
@@ -936,19 +936,17 @@ struct buffer_head *ext3_getblk(handle_t
 			   ext3_get_block instead, so it's not a
 			   problem. */
 			lock_buffer(bh);
-			if (!buffer_uptodate(bh)) {
-				BUFFER_TRACE(bh, "call get_create_access");
-				fatal = ext3_journal_get_create_access(handle, bh);
-				if (!fatal) {
-					memset(bh->b_data, 0,
-							inode->i_sb->s_blocksize);
-					set_buffer_uptodate(bh);
-				}
+			BUFFER_TRACE(bh, "call get_create_access");
+			fatal = ext3_journal_get_create_access(handle, bh);
+			if (!fatal && !buffer_uptodate(bh)) {
+				memset(bh->b_data, 0, inode->i_sb->s_blocksize);
+				set_buffer_uptodate(bh);
 			}
 			unlock_buffer(bh);
 			BUFFER_TRACE(bh, "call ext3_journal_dirty_metadata");
 			err = ext3_journal_dirty_metadata(handle, bh);
-			if (!fatal) fatal = err;
+			if (!fatal)
+				fatal = err;
 		} else {
 			BUFFER_TRACE(bh, "not a new buffer");
 		}

_


  reply	other threads:[~2003-07-26  8:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-26  7:18 Apurva Mehta
2003-07-26  8:54 ` Felipe Alfaro Solana [this message]
2003-07-26 15:38   ` Apurva Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1059209649.577.4.camel@teapot.felipe-alfaro.com \
    --to=felipe_alfaro@linuxmail.org \
    --cc=apurva@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: Random Oopses on 2.6.0-test1-mm2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).